Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl 1.x: fix Mingw build regression #14906

Merged
merged 5 commits into from
Jan 17, 2023
Merged

openssl 1.x: fix Mingw build regression #14906

merged 5 commits into from
Jan 17, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Dec 23, 2022 •
edited
Loading

addresses review in #14066 (comment)

closes #15258

@ghost ghost mentioned this pull request Dec 23, 2022
Closed
@ghost
Copy link

ghost commented Dec 23, 2022

I detected other pull requests that are modifying openssl/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Dec 23, 2022
Closed
4 tasks
@github-actions github-actions bot mentioned this pull request Dec 23, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc
Copy link
Contributor

Is there a profile I could use to test this configuration? I am trying to gather them so I can test this when I make PRs

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Dec 28, 2022

Is there a profile I could use to test this configuration? I am trying to gather them so I can test this when I make PRs

#14066 (comment)

@ericLemanissier ericLemanissier mentioned this pull request Jan 6, 2023
Closed
@SpaceIm SpaceIm closed this Jan 11, 2023
@SpaceIm SpaceIm reopened this Jan 11, 2023
@SpaceIm SpaceIm closed this Jan 12, 2023
@SpaceIm SpaceIm reopened this Jan 12, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request Jan 14, 2023
Closed
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 4 (40e0a131d8c755c77e6d20628f1b815b4ee62fa3):

  • openssl/1.1.1q@:
    All packages built successfully! (All logs)

  • openssl/1.1.1s@:
    All packages built successfully! (All logs)

  • openssl/1.1.0l@:
    All packages built successfully! (All logs)

  • openssl/1.0.2u@:
    All packages built successfully! (All logs)

  • openssl/1.1.1p@:
    All packages built successfully! (All logs)

@SpaceIm SpaceIm mentioned this pull request Jan 17, 2023
Closed
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 17, 2023 •
edited
Loading

@jwillikers @uilianries @ericLemanissier @SSE4 Could you review please? MinGW build of OpenSSL is broken for 1 month.

@conan-center-bot conan-center-bot merged commit 1bf6138 into conan-io:master Jan 17, 2023
@SpaceIm SpaceIm deleted the fix/openssl-1.x-mingw branch January 17, 2023 13:47
franramirez688 pushed a commit to franramirez688/conan-center-index that referenced this pull request Jan 20, 2023
@SpaceIm @franramirez688
(conan-io#14906) openssl 1.x: fix Mingw build regression
f2f5b27 
* fix the win_bash logic mainly for MinGW

* bump zlib & strawberryperl

* move layout() after configure()

* add VirtualBuildEnv since there might be tool requires

* fix openssl installation with MinGW

also properly split nmake & make logic in package()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] openssl/1.1.1s: Configure Error 255 (MinGW Gcc 8)
4 participants
@SpaceIm @conan-center-bot @prince-chrismc @jwillikers