Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding light-curve-python #28791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hombit
Copy link

@hombit hombit commented Jan 8, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • .ci_support/osx_arm64.yaml:
    • lints:
      • Do not edit files outside of the recipes/ directory.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR () and found it was in an excellent condition.

@hombit hombit force-pushed the light-curve-python branch from 7086e79 to 4c1d2e3 Compare January 8, 2025 15:41
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/light-curve-python/meta.yaml) and found some lint.

Here's what I've got...

For recipes/light-curve-python/meta.yaml:

  • requirements: host: maturin>=1,<2 must contain a space between the name and the pin, i.e. maturin >=1,<2
  • requirements: run: numpy<3 must contain a space between the name and the pin, i.e. numpy <3
  • requirements: run: iminuit>=2.21,<3 must contain a space between the name and the pin, i.e. iminuit >=2.21,<3
  • requirements: run: scipy>=1,<2 must contain a space between the name and the pin, i.e. scipy >=1,<2
  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

For recipes/light-curve-python/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package light-curve-python using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12673964927. Examine the logs at this URL for more detail.

@hombit hombit force-pushed the light-curve-python branch from 4c1d2e3 to 6827c4b Compare January 8, 2025 15:48
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/light-curve-python/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/light-curve-python/meta.yaml) and found some lint.

Here's what I've got...

For recipes/light-curve-python/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [33, 41]

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12682088575. Examine the logs at this URL for more detail.

@hombit hombit force-pushed the light-curve-python branch from b055554 to 6fe1dea Compare January 9, 2025 01:23
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/light-curve-python/meta.yaml) and found it was in an excellent condition.

@hombit hombit force-pushed the light-curve-python branch 5 times, most recently from 077e390 to 29b85ce Compare January 9, 2025 14:14
@hombit hombit force-pushed the light-curve-python branch 2 times, most recently from e5667f8 to fbb4e21 Compare January 9, 2025 17:54
@hombit
Copy link
Author

hombit commented Jan 9, 2025

@conda-forge/help-python, it almost ready for review. I have a question about the license: my package is built with Rust and depends on a lot of packages Rust packages. How should I attach licenses to the recipe?

cargo license --no-default-features --features=fftw-system output

(MIT OR Apache-2.0) AND Unicode-3.0 (1): unicode-ident
0BSD (2): enum-iterator, enum-iterator-derive
0BSD OR Apache-2.0 OR MIT (1): adler2
Apache-2.0 (1): noisy_float
Apache-2.0 OR Apache-2.0 WITH LLVM-exception OR MIT (1): wasi
Apache-2.0 OR BSD-2-Clause OR MIT (2): zerocopy, zerocopy-derive
Apache-2.0 OR BSL-1.0 (1): ryu
Apache-2.0 OR MIT (91): addr2line, autocfg, backtrace, bitflags, cfg-if, crossbeam-deque, crossbeam-epoch, crossbeam-utils, custom_derive, dyn-clone, either, enum_dispatch, enumflags2, enumflags2_derive, equivalent, error-chain, getrandom, gimli, hashbrown, heck, hermit-abi, indexmap, indoc, inventory, iter-read, itertools, itertools, itoa, lazy_static, libc, matrixmultiply, ndarray, ndarray, ndarray-stats, num-bigint, num-complex, num-integer, num-traits, num_cpus, object, once_cell, paste, portable-atomic, portable-atomic-util, ppv-lite86, proc-macro2, pyo3, pyo3-build-config, pyo3-ffi, pyo3-macros, pyo3-macros-backend, quote, rand, rand, rand, rand_chacha, rand_core, rand_core, rand_core, rand_xoshiro, rawpointer, rayon, rayon-core, rustc-demangle, rustc-hash, rustversion, serde, serde-pickle, serde_derive, serde_derive_internals, serde_json, syn, thiserror, thiserror, thiserror-impl, thiserror-impl, thread_local, unicode-xid, unindent, winapi, winapi-i686-pc-windows-gnu, winapi-x86_64-pc-windows-gnu, windows-targets, windows_aarch64_gnullvm, windows_aarch64_msvc, windows_i686_gnu, windows_i686_gnullvm, windows_i686_msvc, windows_x86_64_gnu, windows_x86_64_gnullvm, windows_x86_64_msvc
Apache-2.0 OR MIT OR Zlib (1): miniz_oxide
Apache-2.0 WITH LLVM-exception (1): target-lexicon
Apache-2.0) OR MIT AND (MIT (1): libm
BSD-2-Clause (1): numpy
Custom License File (3): fftw, fftw-sys, fuchsia-cprng
GPL-3.0-or-later (2): light-curve-feature, light-curve-python
ISC (1): rdrand
MIT (8): conv, emcee, light-curve-dmdt, macro_const, memoffset, schemars, schemars_derive, unzip3
MIT OR Unlicense (2): byteorder, memchr
Zlib (2): const_format, const_format_proc_macros

@synapticarbors
Copy link
Member

see:
https://conda-forge.org/docs/maintainer/adding_pkgs/#licenses-of-included-dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants