Skip to content

Commit

Permalink
regenerate some text files
Browse files Browse the repository at this point in the history
commands used for regeneration:
$ git grep FIXME | grep -v FIXMES.txt > FIXMES.txt
$ git grep " XXX" | grep -v XXX.txt > XXX.txt
(note the leading space)
Also some other changes
  • Loading branch information
cooljeanius committed Jun 29, 2024
1 parent c39ea4f commit 0beb756
Show file tree
Hide file tree
Showing 10 changed files with 104 additions and 23 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
run: |
case ${{ matrix.os }} in
ubuntu*)
sudo apt-get -y install libc6-dev-amd64-cross libgcc-s1-amd64-cross libtbb-dev gobjc gobjc-multilib xutils-dev publib-dev libiberty-dev libc6-dev-i386 libmm-dev kmod libc-bin dcfldd libtree buildd mini-buildd
sudo apt-get -qq install libc6-dev-amd64-cross libgcc-s1-amd64-cross libtbb-dev gobjc gobjc-multilib xutils-dev publib-dev libiberty-dev libc6-dev-i386 libmm-dev kmod libc-bin dcfldd libtree buildd mini-buildd
if test -x /home/linuxbrew/.linuxbrew/bin/brew; then \
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"; \
else \
Expand Down
27 changes: 18 additions & 9 deletions FIXMES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,18 @@ configure:# FIXME: To remove some day.
configure:# FIXME: To remove some day.
configure: # FIXME: It is wrong to rewrite CC.
configure: # FIXME: It is wrong to rewrite AR.
configure: # FIXME: It is wrong to rewrite AR.
configure:# ARFLAGS for automake and AR_FLAGS for libtool). FIXME: Make the AR_FLAGS
configure: # FIXME: we need at least 68020 code to build shared libraries, but
configure: # FIXME: the MSVC++ port hasn't been tested in a loooong time
configure: # FIXME: the MSVC++ and ICC port hasn't been tested in a loooong time
configure: # support --undefined. This deserves some investigation. FIXME
configure: # FIXME: Setting linknames here is a bad hack.
configure: # FIXME: Setting linknames here is a bad hack.
configure: # FIXME: Should let the user specify the lib program.
configure: # FIXME: we may have to deal with multi-command sequences.
configure: # FIXME: find the short name or the path components, as spaces are
configure: # FIXME: first we should search . and the directory the executable is in
configure:# FIXME - insert some real tests, host_os isn't really good enough
configure: # FIXME - insert some real tests, host_os isn't really good enough
configure: # FIXME: insert proper C++ library support
configure: # support --undefined. This deserves some investigation. FIXME
configure: # FIXME: insert proper C++ library support
Expand Down Expand Up @@ -100,15 +102,17 @@ configure: # FIXME: we may have to deal with multi-command sequences.
configure: # FIXME: find the short name or the path components, as spaces are
configure: # FIXME: first we should search . and the directory the executable is in
configure: #FIXME: config.log reports a path found for these, but still says "no":
configure: { $as_echo "$as_me:${as_lineno-$LINENO}: checking for FIXME existence of three headers" >&5
configure:$as_echo_n "checking for FIXME existence of three headers... " >&6; }
configure: # FIXME -- no need to abort building the whole package
configure: { $as_echo "$as_me:${as_lineno-$LINENO}: checking for FIXME existence of three headers" >&5
configure:$as_echo_n "checking for FIXME existence of three headers... " >&6; }
configure:# FIXME: these may require some additional flags:
configure: { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking for FIXME existence of three headers" >&5
configure:printf %s "checking for FIXME existence of three headers... " >&6; }
configure: # FIXME -- no need to abort building the whole package
configure: { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking for FIXME existence of three headers" >&5
configure:printf %s "checking for FIXME existence of three headers... " >&6; }
configure: # FIXME -- no need to abort building the whole package
configure:# FIXME: This hack should be removed a few years after 2.60.
configure:# FIXME: do we really want to maintain this feature?
configure.ac: dnl#FIXME: make sure these flags are actually used properly
configure.ac:# FIXME: these may require some additional flags:
fallocate.c:/* FIXME: look at orig email for this file definition. */
fallocate.c: return ENOSYS; /* FIXME: glibc interface may change to set errno and ret -1 */
fallocate.c: /* FIXME: support fcntl(fd, F_ALLOCSP, ...) on solaris. */
Expand Down Expand Up @@ -143,16 +147,18 @@ localename.c: /* FIXME: Adjust this when such locales appear on Unix. */
localename.c: /* FIXME: Adjust this when such locales appear on Unix. */
localename.c: /* FIXME: Adjust this when Tamazight locales appear on Unix. */
m4/ccstdc.m4:dnl# FIXME: cannot do this because then AC_USE_SYSTEM_EXTENSIONS will NOT
m4/extensions.m4:dnl (FIXME: Which ones?)
m4/include_next.m4:dnl# FIXME: gl_next_header and gl_header_exists must be used unquoted
m4/lib-link.m4: dnl FIXME: Not sure whether we should use
m4/lib-link.m4: dnl FIXME: Not sure whether we should use
m4/libtool.m4:## FIXME: Eliminate VARNAME ##
m4/libtool.m4:# FIXME - insert some real tests, host_os isn't really good enough
m4/libtool.m4:# ARFLAGS for automake and AR_FLAGS for libtool). FIXME: Make the AR_FLAGS
m4/libtool.m4: # FIXME - insert some real tests, host_os isn't really good enough
m4/libtool.m4: # FIXME: find the short name or the path components, as spaces are
m4/libtool.m4: # FIXME: first we should search . and the directory the executable is in
m4/libtool.m4: # FIXME: we need at least 68020 code to build shared libraries, but
m4/libtool.m4: # FIXME: we need at least 68020 code to build shared libraries, but
m4/libtool.m4: # FIXME: the MSVC++ port hasn't been tested in a loooong time
m4/libtool.m4: # FIXME: the MSVC++ and ICC port hasn't been tested in a loooong time
m4/libtool.m4: # support --undefined. This deserves some investigation. FIXME
m4/libtool.m4: # FIXME: Setting linknames here is a bad hack.
m4/libtool.m4: # FIXME: Setting linknames here is a bad hack.
Expand Down Expand Up @@ -186,6 +192,8 @@ m4/libtool.m4: # FIXME: insert proper C++ library support
m4/libtool.m4: # FIXME: insert proper C++ library support
m4/ls-mntd-fs.m4: AC_MSG_CHECKING([for FIXME existence of three headers])
m4/ls-mntd-fs.m4: # FIXME -- no need to abort building the whole package
m4/mountlist.m4: AC_CACHE_CHECK([for FIXME existence of three headers],
m4/mountlist.m4: # FIXME -- no need to abort building the whole package
m4/programs_extra.m4: dnl# FIXME: are all of these correct?
m4/programs_extra.m4: #FIXME: config.log reports a path found for these, but still says "no":
m4/warn-on-use.m4:dnl# FIXME: gl_Symbol must be used unquoted until we can assume
Expand All @@ -195,3 +203,4 @@ mktime.c:/* FIXME: This should use a signed type wide enough to hold any UTC
openat-proc.c: FIXME - if the kernel ever adds support for multi-thread safety for
pipe2.c: /* FIXME: clang says that this condition will never be reached...
quotearg.c: /* FIXME: technically, the type of n1 should be 'unsigned int',
strerror_r.c:/* FIXME: ought to return char * instead? */
2 changes: 1 addition & 1 deletion Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -1646,7 +1646,7 @@ getopttest_CFLAGS = $(getopttest_CPPFLAGS) -Wall -Wextra -ggdb3

## extra test dependencies:
check-local: all
if test -x "`which machocheck`" -a -d .libs -a -r .libs/libUnixToOSX.dylib; then \
if test -x "`which machocheck`" -a -d .libs -a -r .libs/libUnixToOSX.dylib -a -x .libs/libUnixToOSX.dylib; then \
machocheck -progress .libs/libUnixToOSX.dylib; \
else \
echo "skipping checks of mach-o format validity"; \
Expand Down
2 changes: 1 addition & 1 deletion Makefile.in

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions XXX.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
argp/argp-standalone-1.3/argp.h:#define ARGP_ERR_UNKNOWN E2BIG /* Hurd should never need E2BIG. XXX */
build-aux/config.guess: if (strncmp(un.version, "V1", 2) == 0) { /* XXX is V1 correct? */
build-aux/config.guess: if (strncmp(un.version, "V1", 2) == 0) { /* XXX is V1 correct? */
configure: # XXX I think wlarc can be eliminated in ltcf-cxx, but I need to
crypt.c: * XXX: this feature is currently unused, see "endian" comment below.
getopt.c: XXX This is no good solution. We should rather copy the args so
libftw0/Fink/libftw0.patch:+ /* XXX - nfds is currently unused */
libftw0/ftw.c: /* XXX - nfds is currently unused */
libftw0/ftw.c: /* XXX: nfds is currently unused */
m4/libtool.m4: # XXX I think wlarc can be eliminated in ltcf-cxx, but I need to
m4/xorg-macros.m4:# For XXX in {TXT, PDF, PS, HTML}, the AM_CONDITIONAL "BUILD_XXXDOC"
stddef.in.h:#endif /* __need_XXX */
71 changes: 69 additions & 2 deletions configure

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,10 @@ if test "x${ac_cv_search_CFPreferencesCopyAppValue}y" != "xnoy"; then
AC_DEFINE([CFPREFERENCESCOPYAPPVALUE_OK_TO_LINK],[1],
[Define to 1 if we are ok to link w/a library for CFPreferencesCopyAppValue])
fi
AC_SEARCH_LIBS([__fpending],[c System magic pub gnu iberty fpending]) ## (ok)
AC_SEARCH_LIBS([chdir_long],[c System magic pub gnu iberty chdir]) ## (newline)
AC_SEARCH_LIBS([dupfd],[c System magic pub gnu iberty dup dupfd])dnl
AC_SEARCH_LIBS([__fpending],[c System magic pub gnu iberty fpending])
AC_SEARCH_LIBS([chdir_long],[c System magic pub gnu iberty chdir])
AC_SEARCH_LIBS([dupfd],[c System magic pub gnu iberty dup dupfd])
AC_SEARCH_LIBS([fd_safer_flag],[c System magic pub gnu iberty fd])dnl

# Threading.
AC_MSG_CHECKING([for threading library characteristics...])
Expand Down
7 changes: 5 additions & 2 deletions error.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,11 @@ print_errno_message(int errnum)
#endif /* _LIBC */
}

static void error_tail(int status, int errnum, const char *message,
va_list args)
static void
#if defined(_GL_ATTRIBUTE_FORMAT_PRINTF_STANDARD) && defined(_GL_ARG_NONNULL)
_GL_ATTRIBUTE_FORMAT_PRINTF_STANDARD(3, 0) _GL_ARG_NONNULL((3))
#endif /* _GL_ATTRIBUTE_FORMAT_PRINTF_STANDARD && _GL_ARG_NONNULL */
error_tail(int status, int errnum, const char *message, va_list args)
{
int should_do_vprintf = 1;
#if defined(_LIBC) && _LIBC
Expand Down
1 change: 1 addition & 0 deletions obstack_printf.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#if defined(__GNUC__) && defined(__GNUC_MINOR__)
# if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 1))
# pragma GCC diagnostic ignored "-Wredundant-decls"
# pragma GCC diagnostic ignored "-Wformat-nonliteral"
# endif /* GCC 4.1+ */
#endif /* gcc */

Expand Down
2 changes: 1 addition & 1 deletion stddef.in.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,4 @@

# endif /* _@GUARD_PREFIX@_STDDEF_H */
# endif /* _@GUARD_PREFIX@_STDDEF_H */
#endif /* __need_XXX */
#endif /* __need_[wchar_t|size_t|ptrdiff_t|NULL|wint_t] */

0 comments on commit 0beb756

Please sign in to comment.