Fixed blocksGroupWithPartition unable to reuse functions from blocksGroup #6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roup Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
danielblando
approved these changes
Jan 24, 2025
yeya24
approved these changes
Jan 24, 2025
CharlieTLe
pushed a commit
to CharlieTLe/cortex
that referenced
this pull request
Jan 24, 2025
…roup (cortexproject#6547) * Fixed blocksGroupWithPartition unable to reuse functions from blocksGroup Signed-off-by: Alex Le <[email protected]> * update tests Signed-off-by: Alex Le <[email protected]> --------- Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
blocksGroupWithPartitionextendsblocksGroup. However, when calling functions insideblocksGroupfrom ablocksGroupWithPartitioninstance, those attributes defined insideblocksGroupwere not set properly when initializeblocksGroupWithPartition. This caused unexpected value returned fromblocksGroupfunctions.The fix is removing duplicate attributes from
blocksGroupWithPartitionthat already defined insideblocksGroup. When initializingblocksGroupWithPartitioninstance, those attributes inblocksGroupshould be explicitly provided.Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]