dcache-billing-indexer: add explicit dependency on commons-io #7739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: the dcache-billing-indexer uses commons-compress to handle bz2 files, and has non-optional dependency on commons-io, which is missing. So we get: ``` /usr/sbin/dcache-billing-indexer -index /var/lib/dcache/billing/2025/01/billing-2025.01.27.bz2 ERROR - Uncaught exception java.lang.NoClassDefFoundError: org/apache/commons/io/input/CloseShieldInputStream at org.dcache.services.billing.text.Indexer$7.openStream(Indexer.java:526) at com.google.common.io.ByteSource$AsCharSource.openStream(ByteSource.java:474) at com.google.common.io.CharSource.readLines(CharSource.java:371) at org.dcache.services.billing.text.Indexer.produceIndex(Indexer.java:510) at org.dcache.services.billing.text.Indexer.index(Indexer.java:396) at org.dcache.services.billing.text.Indexer.(Indexer.java:211) at org.dcache.services.billing.text.Indexer.main(Indexer.java:686) Caused by: java.lang.ClassNotFoundException: org.apache.commons.io.input.CloseShieldInputStream at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525) ... 7 common frames omitted ``` Modification: explicitly add commons-io into dcache-billing-indexer classpath. Result: dcache-billing-indexer can process compressed files. Fixes: #7738 Acked-by: Lea Morschel Tested-by: Ville Salmela Target: master, 10.2 Require-book: no Require-notes: yes (cherry picked from commit 153a018) Signed-off-by: Tigran Mkrtchyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
the dcache-billing-indexer uses commons-compress to handle bz2 files, and has non-optional dependency on commons-io, which is missing. So we get:
Modification:
explicitly add commons-io into dcache-billing-indexer classpath.
Result:
dcache-billing-indexer can process compressed files.
Fixes: #7738
Acked-by: Lea Morschel
Tested-by: Ville Salmela
Target: master, 10.2
Require-book: no
Require-notes: yes
(cherry picked from commit 153a018)