Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in README #206

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

alexey-milovidov
Copy link
Contributor

@alexey-milovidov alexey-milovidov commented Jun 7, 2024

Pull Request Template

Description

The command will not work in bash or Bourne-compatible shell without quoting.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

It didn't.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

The command will not work in bash or Bourne-compatible shell without quoting.
@alexey-milovidov
Copy link
Contributor Author

I see that some places in readme use double quotes " without a need. But I used single quotes in this example because double quotes in shell are more dangerous to use than single quotes.

@danvergara danvergara self-requested a review June 7, 2024 17:21
@danvergara danvergara added the kind/docs Improvements or additions to documentation label Jun 7, 2024
@danvergara danvergara merged commit 60d5388 into danvergara:main Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants