Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ssh tunnel connection handling and closing #249

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

danvergara
Copy link
Owner

@danvergara danvergara commented Jan 6, 2025

Fix ssh tunnel connection handling

Description

This PR fixes a bug addressed on #205 and it had to do with the way the ssh tunnel connection was handled. I rushed up the release of this feature and did not QA'd it too much and I did not handle the connection properly.

Fixes #205

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested this bugfix against the services listed on the ssh related compose file

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara self-assigned this Jan 6, 2025
This was referenced Jan 6, 2025
@danvergara danvergara changed the title fix the way the ssh tunnel connection was closed fix ssh tunnel connection handling and closing Jan 6, 2025
@danvergara danvergara merged commit fe46535 into main Jan 7, 2025
8 checks passed
@danvergara danvergara deleted the fix-ssh-tunnel-close-connection branch January 7, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] SSH tunnel support
1 participant