Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from classes to attributes #3

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Move from classes to attributes #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 37 additions & 17 deletions podcast-player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ class PodcastPlayer extends LitElement {
currentTime: { type: String },
currentSpeedIdx: { type: Number },
duration: { type: String },
playing: { type: Boolean, reflect: true },
muted: { type: Boolean, reflect: true },
};
}

// TODO: Make styles optional? Easily overrideable?
static get styles() {
return css`
.sr-only {
.sr-only {
clip: rect(0 0 0 0);
clip-path: inset(50%);
height: 1px;
Expand All @@ -26,10 +28,10 @@ class PodcastPlayer extends LitElement {
width: 1px;
}
.podcast-player {
.podcast-player {
display: flex;
gap: 0.5rem;
width:100%;
width: 100%;
align-items: center;
grid-gap: 0.5rem;
}
Expand All @@ -45,18 +47,18 @@ class PodcastPlayer extends LitElement {
/* Speed */
.podcast-player .button-speed:after {
content: 'x';
content: "x";
}
/* Play/Pause */
.button-play .pause {
display: none;
}
:host(.is-playing) .button-play .pause {
:host([playing]) .button-play .pause {
display: inline;
}
:host(.is-playing) .button-play .play {
:host([playing]) .button-play .play {
display: none;
}
Expand All @@ -65,11 +67,11 @@ class PodcastPlayer extends LitElement {
display: none;
}
:host(.is-muted) .button-mute .muted {
:host([muted]) .button-mute .muted {
display: inline;
}
:host(.is-muted) .button-mute .unmuted {
:host([muted]) .button-mute .unmuted {
display: none;
}
`;
Expand All @@ -86,13 +88,15 @@ class PodcastPlayer extends LitElement {
this.currentSpeedIdx = 0;
this.currentTime = 0;
this.duration = 0;
this.playing = false;
this.muted = false;

this.audio.addEventListener("timeupdate", this.handleTimeUpdate.bind(this));
this.audio.addEventListener(
"loadedmetadata",
this.handleLoadedMetadata.bind(this)
);
this.audio.addEventListener('ended', this.stop.bind(this))
this.audio.addEventListener("ended", this.stop.bind(this));

window.addEventListener(
"DOMContentLoaded",
Expand Down Expand Up @@ -134,7 +138,7 @@ class PodcastPlayer extends LitElement {

this.audio.currentTime = timestamp;
this.audio.play();
this.classList.add("is-playing");
this.playing = true;
},
false
);
Expand Down Expand Up @@ -194,7 +198,7 @@ class PodcastPlayer extends LitElement {

mute() {
this.audio.muted = !this.audio.muted;
this.classList.toggle("is-muted", this.audio.muted);
this.muted = this.audio.muted;
}

play() {
Expand All @@ -204,11 +208,11 @@ class PodcastPlayer extends LitElement {
} else {
this.audio.pause();
}
this.classList.toggle("is-playing", !this.audio.paused);
this.playing = !this.audio.paused;
}

stop() {
this.classList.toggle("is-playing", !this.audio.paused);
this.playing = !this.audio.paused;
}

rewind() {
Expand Down Expand Up @@ -271,7 +275,12 @@ class PodcastPlayer extends LitElement {
30<br /><<&mdash;
</button>
<button class="button-play" aria-label="Play" style="grid-area: play" @click="${this.play}">
<button
class="button-play"
aria-label="Play"
style="grid-area: play"
@click="${this.play}"
>
<svg class="play"><use xlink:href="#icon-play"></use></svg>
<svg class="pause"><use xlink:href="#icon-pause"></use></svg>
</button>
Expand All @@ -287,7 +296,9 @@ class PodcastPlayer extends LitElement {
<div style="grid-area: currenttime">
<span class="sr-only">Current Time</span>
<span class="currenttime time" >${this.toHHMMSS(this.currentTime)}</span>
<span class="currenttime time"
>${this.toHHMMSS(this.currentTime)}</span
>
</div>
<input
Expand All @@ -304,11 +315,20 @@ class PodcastPlayer extends LitElement {
<span class="duration time">${this.toHHMMSS(this.duration)}</span>
</div>
<button class="button-speed" style="grid-area: speed" @click="${this.changeSpeed}">
<button
class="button-speed"
style="grid-area: speed"
@click="${this.changeSpeed}"
>
${this.speeds[this.currentSpeedIdx]}
</button>
<button class="button-mute" aria-label="Mute" style="grid-area: mute" @click="${this.mute}">
<button
class="button-mute"
aria-label="Mute"
style="grid-area: mute"
@click="${this.mute}"
>
<svg class="unmuted">
<use xlink:href="#icon-speaker-unmuted"></use>
</svg>
Expand Down