Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace DB icons with whitelabel open source icons #3653

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: replace DB icons with whitelabel open source icons #3653

wants to merge 9 commits into from

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Jan 8, 2025

Proposed changes

Replaced DB icons with whitelabel open source icons

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-whitelabel-icons

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Jan 8, 2025
mfranzke
mfranzke reviewed Jan 8, 2025
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
nmerget added 3 commits January 9, 2025 08:45
@nmerget
fix: linting issues
11b89ec
@nmerget
chore: update to icon-font-tools
6702139
@nmerget
Merge remote-tracking branch 'origin/main' into feat-whitelabel-icons
d56a849 
# Conflicts:
#	packages/foundations/scripts/local/generate-icon-overview.ts
#	packages/foundations/src/icons.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke left review comments

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke