Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor / additional flag autoGenerateIamPermissions #1089

Merged
merged 10 commits into from
Jan 20, 2025

Conversation

markussiebert
Copy link
Contributor

Fixes #1076, #1087

- remove CreationType (Single, Multi)
- replace with ResourceType (PARAMETER_MULTI) and move it to properties
   fixes: #1076
- add property 'autoGenerateIamPermissions'
   fixes: #1087
- add property 'role' for SopsSyncProvider
   fixes: #1087
- move resourceType from syncOptions to syncProperties, as it shouldn't be set by users
- move permissionhandling to own functions, to reduce cyclomatic compexity
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 45.76271% with 32 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (1e69765) to head (7a57321).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lambda/main.go 45.76% 29 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   72.30%   71.80%   -0.51%     
==========================================
  Files           3        3              
  Lines         455      461       +6     
==========================================
+ Hits          329      331       +2     
- Misses         88       91       +3     
- Partials       38       39       +1     
Flag Coverage Δ
go-lambda 71.80% <45.76%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenderom
Copy link
Member

I've build this branch local and deployed it without problems in our MultiParameter setup. 👍

markussiebert and others added 2 commits January 15, 2025 15:39
Copy link
Contributor

@henrysachs henrysachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markussiebert markussiebert merged commit 7f8a318 into main Jan 20, 2025
10 of 12 checks passed
@markussiebert markussiebert deleted the feat/1087 branch January 20, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make lambda role configurable Improve usability for SSM:Parameters - remove public property ResourceType
3 participants