[WIP] fixing planemo tests #1375
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Jan 24, 2025
| <output name="outFileName" file="bamCompare_result1.bg" ftype="bedgraph"/> | ||
| <output name="outFileName" ftype="bedgraph"> | ||
| <assert_contents> | ||
| <has_text_matching expression="chrM\t0\t16569\t1"/> |
There was a problem hiding this comment.
why did you choose to drop the file comparison?
Its a pretty good test to see the differences between both versions.
There was a problem hiding this comment.
There is only one line in the output :)
There was a problem hiding this comment.
then please add an assert for the line_counts as well :)
bgruening
reviewed
Jan 24, 2025
| @@ -267,10 +281,12 @@ | |||
| <test expect_num_outputs="1"> | |||
| <param name="bamFile1" value="testA.bam" ftype="bam"/> | |||
| <param name="bamFile2" value="testB.bam" ftype="bam"/> | |||
| <param name="showAdvancedOpt" value="yes"/> | |||
| <param name="method" value="own"/> | |||
There was a problem hiding this comment.
should'nt this be in a conditional like above?
There was a problem hiding this comment.
Yes, these need to be fixed. I wrote in the matrix an issue with the tool. I can not test it ATM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :