-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'UnixMode' on *nix platforms instead of Windows-only 'Mode' #98
base: main
Are you sure you want to change the base?
Conversation
@devblackops A gentle reminder =) |
@devblackops Another ping=) |
@ShrykeWindgrace Sorry for not responding earlier. It looks like there are potential variations on whether pwsh includes a |
@devblackops Hm, that's a good point. I'll check what is available where, since we can have a pure windows setup, a pure *nix setup, a WSL1 looking into a WSL file and into a windows file, and then again there's WSL2 looking into its own files or into windows files... I have a suspicion that we will be hitting the limitations of what is possible with I'll keep you posted. |
I ran my tests to cover the combinatorics. Summary: I do not have a valid Config:
I do not have access to a native linux environment today, but I am confident that There might have been a change of I'll to get a |
On a 7.1.3 the situation is even funnier. Despite the documentation insisting on the presence of That being said, Anyways, one could consider a different approach altogether - instead of having |
@devblackops Can we please get a movement here? Thank you |
Description
I had to increase the width of the
Mode
colum to10
(was7
), otherwise it wraps. We can not add a switch on the OS in the definition of this width, the XML schema would not allow that; we could create format on the fly, but that seems like significant refactoring with possible impact ongci
's latency.Otherwise, the change is a simple switch over the OS to select an appropriate property of the file to be rendered.
Related Issue
#66
Motivation and Context
It allows showing *nix file permissions on non-windows platforms.
How Has This Been Tested?
Tested on my Debian. The tests run by
./build.ps1
are all green, the imported module shows unix permissions/windows permissions depending on the platform.Screenshots (if appropriate):
Types of changes
Checklist: