[WIP] Feature/facebook login #6
Conversation
|
|
||
| // A trip represents a one-time visit to a particular country | ||
| type Trip struct { | ||
| Id string `json:"id"` | ||
| User string `json:"user"` | ||
| Place string `json:"place"` | ||
| Country string `json:"country"` |
There was a problem hiding this comment.
This should probably be a Country struct at some point.
There was a problem hiding this comment.
Agree. Everything you see here is very WIP at the moment. Our idea was to use an external API for countries, but I'm not sure yet which options we would have
| ) | ||
|
|
||
| const userConfFilename string = "conf.json" | ||
|
|
||
| // TODO: Move this to API | ||
| func Ping(w http.ResponseWriter, r *http.Request, ps httprouter.Params) { | ||
| fmt.Fprint(w, "pong") |
| @@ -0,0 +1,8 @@ | |||
| package models | |||
There was a problem hiding this comment.
I'd rather move this into an input/api validator rather than a models validator. I'd even put it into a parser module and return the actual Time rather than using a string within the model.
| "io/ioutil" | ||
| ) | ||
|
|
||
| func Login(w http.ResponseWriter, r *http.Request, ps httprouter.Params, a *config.Config) { |
There was a problem hiding this comment.
I'm not sure I understand this endpoint. Could you detail it?
There was a problem hiding this comment.
Our idea is to allow 3rd-party login via Facebook, right? This endpoint is used by the client to request the user to log in. It redirects the user to a Facebook login page with our app's information. When the user clicks on "accept" or "reject", Facebook calls the LoginWithFacebook callback with an access token corresponding to the user, and then we can get their data (email, name, ...)
One of the main ideas of this is that in the future maybe we can parse the metadata of pictures to create an interactive map of where they've been and with whom.
| @@ -0,0 +1,50 @@ | |||
| package trip_repo | |||
There was a problem hiding this comment.
AFAIK it's not recommended to use _ within package name, right?
There was a problem hiding this comment.
True. It's not very Go-y. What package structure and names would you use?
There was a problem hiding this comment.
Following go coding style I'd say triprepo
|
|
||
| repo.trips[trip.Id] = trip | ||
| return nil | ||
| } |
There was a problem hiding this comment.
There's a new line missing at the end of some of your files.
There was a problem hiding this comment.
Could be I didn't even go fmt the whole thing
No description provided.