-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to configure ODL user/pass #140
base: master
Are you sure you want to change the base?
Conversation
lib/puppet/provider/odl_user/idm.rb
Outdated
end | ||
|
||
def idm_cmd(*args) | ||
java('-jar', "#{odl_path}/bin/aaa-cli-jar-0.5.0-SNAPSHOT.jar", '--dbd', odl_path, *args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note I need to see if I can get Michael to rename this jar to eliminate the version name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your wish is my command ;) see https://git.opendaylight.org/gerrit/#/c/54388/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update this to get Beaker tests passing
@trozet |
We need this bugfix before Beaker test will pass |
We have a patch to not include ODL's version in the JAR |
as requested on dfarrell07/puppet-opendaylight#140 Change-Id: Ifdb3e87cee4cb80f0c753ead620077cbf98af0f8 Signed-off-by: Michael Vorburger <[email protected]>
Project: integration/distribution master 6410d432b02f0cb28564be5b80589b39316e194e bin/aaa-cli-jar.jar without version number as requested on dfarrell07/puppet-opendaylight#140 Change-Id: Ifdb3e87cee4cb80f0c753ead620077cbf98af0f8 Signed-off-by: Michael Vorburger <[email protected]>
Still failing for me https://pastebin.com/3R1WAYVS |
Talked to @trozet, both thought it would be good to re-spin RPM (to be totally sure @vorburger's change is in the snapshot) and test again. We have a snapshot build from today in 6-testing And I noticed this line in the log
Which pointed me to this line in the PR
We need to update the filename to not include a version now that @vorburger's change to not include a version in the JAR is merged/shipping. |
Signed-off-by: Tim Rozet <[email protected]>
35ed172
to
0d20f1b
Compare
@dfarrell07 this should work now, it passes docker acceptance with carbon. We should probably update the Rakefile to remove older versions for the acceptance testing in puppet-opendaylight master branch |
@trozet I have a new dev laptop (old one crashed so hard RH IT gave me my upgrade early as replacement), on which Docker+Beaker consistently crashes my kernel. :( Just running containers with Docker is fine, but something like Running Beaker in VMs, I'm hitting this issue https://tickets.puppetlabs.com/browse/BKR-972 It was supposed to be fixed in this PR Which is in 3.14.0 (the latest release, release I'm using) |
@trozet can you send this to the new ODL-manged repos? Should just require adding a new remote, setting up git-review and pushing. https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=summary |
Signed-off-by: Tim Rozet [email protected]