Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to configure ODL user/pass #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trozet
Copy link
Collaborator

@trozet trozet commented Apr 5, 2017

Signed-off-by: Tim Rozet [email protected]

end

def idm_cmd(*args)
java('-jar', "#{odl_path}/bin/aaa-cli-jar-0.5.0-SNAPSHOT.jar", '--dbd', odl_path, *args)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note I need to see if I can get Michael to rename this jar to eliminate the version name.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your wish is my command ;) see https://git.opendaylight.org/gerrit/#/c/54388/

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this to get Beaker tests passing

@dfarrell07
Copy link
Owner

@trozet bundle exec rake sanity is showing some relevant-seeming errors for me

https://pastebin.com/vrMM8jdq

@dfarrell07
Copy link
Owner

We need this bugfix before Beaker test will pass

https://git.opendaylight.org/gerrit/#/c/54350/

@dfarrell07
Copy link
Owner

We have a patch to not include ODL's version in the JAR

https://git.opendaylight.org/gerrit/#/c/54388/

odl-github pushed a commit to opendaylight/integration-distribution that referenced this pull request Apr 6, 2017
as requested on dfarrell07/puppet-opendaylight#140

Change-Id: Ifdb3e87cee4cb80f0c753ead620077cbf98af0f8
Signed-off-by: Michael Vorburger <[email protected]>
odl-github pushed a commit to opendaylight/releng-autorelease that referenced this pull request Apr 6, 2017
Project: integration/distribution master 6410d432b02f0cb28564be5b80589b39316e194e

bin/aaa-cli-jar.jar without version number

as requested on dfarrell07/puppet-opendaylight#140

Change-Id: Ifdb3e87cee4cb80f0c753ead620077cbf98af0f8
Signed-off-by: Michael Vorburger <[email protected]>
@dfarrell07
Copy link
Owner

Still failing for me https://pastebin.com/3R1WAYVS

@dfarrell07
Copy link
Owner

dfarrell07 commented Apr 13, 2017

Talked to @trozet, both thought it would be good to re-spin RPM (to be totally sure @vorburger's change is in the snapshot) and test again.

We have a snapshot build from today in 6-testing

http://cbs.centos.org/repos/nfv7-opendaylight-6-testing/x86_64/os/Packages/opendaylight-6.0.0-0.1.20170413snap4880.el7.noarch.rpm

And bundle exec rake sanity (which uses 6-testing) is still failing

https://pastebin.com/Xs3dLRLx

I noticed this line in the log

�[00;00m�[00;33m Error: /Stage[main]/Opendaylight::Config/Odl_user[admin]: Could not evaluate: Execution of '/usr/bin/java -jar /opt/opendaylight/bin/aaa-cli-jar-0.5.0-SNAPSHOT.jar --dbd /opt/opendaylight -l' returned 1: Error: Unable to access jarfile /opt/opendaylight/bin/aaa-cli-jar-0.5.0-SNAPSHOT.jar

Which pointed me to this line in the PR

lib/puppet/provider/odl_user/idm.rb:10: java('-jar', "#{odl_path}/bin/aaa-cli-jar-0.5.0-SNAPSHOT.jar", '--dbd', odl_path, *args

We need to update the filename to not include a version now that @vorburger's change to not include a version in the JAR is merged/shipping.

@trozet trozet force-pushed the add_odl_user_password branch from 35ed172 to 0d20f1b Compare April 18, 2017 19:35
@trozet
Copy link
Collaborator Author

trozet commented Apr 18, 2017

@dfarrell07 this should work now, it passes docker acceptance with carbon. We should probably update the Rakefile to remove older versions for the acceptance testing in puppet-opendaylight master branch

@dfarrell07
Copy link
Owner

@trozet I have a new dev laptop (old one crashed so hard RH IT gave me my upgrade early as replacement), on which Docker+Beaker consistently crashes my kernel. :( Just running containers with Docker is fine, but something like bundle exec rake cent_6test_dock makes things crash and burn.

Running Beaker in VMs, I'm hitting this issue

https://tickets.puppetlabs.com/browse/BKR-972

It was supposed to be fixed in this PR

voxpupuli/beaker#1313

Which is in 3.14.0 (the latest release, release I'm using)

@dfarrell07
Copy link
Owner

dfarrell07 commented Apr 25, 2017

@trozet can you send this to the new ODL-manged repos? Should just require adding a new remote, setting up git-review and pushing.

https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=summary

@trozet
Copy link
Collaborator Author

trozet commented Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants