Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply prettier to css files #247

Closed
wants to merge 1 commit into from
Closed

Conversation

ulgens
Copy link
Contributor

@ulgens ulgens commented Dec 13, 2024

Coming from #238 (comment)

@ulgens ulgens marked this pull request as ready for review December 13, 2024 17:29
@ulgens
Copy link
Contributor Author

ulgens commented Dec 13, 2024

@bmispelon Not sure how to proceed with this one, waiting for your input.

@bmispelon
Copy link
Member

Thanks for adding this!

I don't think output.css should be reformatted, since it's compiled from the files in the scss directory (I think that means we can keep ignoring the css files in the prettier hook).
Similarly with webfont.js: from what I understand it's a vendored library that we just copied in to the project, so I would rather not touch it.

But everything else I'm up for autoformatting 👍🏻

@bmispelon
Copy link
Member

django/djangoproject.com#1838 added a prettier config for djangoproject.com, I suggest we adopt the same rules here

@ulgens
Copy link
Contributor Author

ulgens commented Dec 21, 2024

@bmispelon #248 🎈

@ulgens ulgens marked this pull request as draft December 21, 2024 11:56
@ulgens ulgens changed the title Apply prettier to css and javascript files Apply prettier to css files Dec 28, 2024
@ulgens
Copy link
Contributor Author

ulgens commented Dec 28, 2024

I don't think output.css should be reformatted, since it's compiled from the files in the scss directory (I think that means we can keep ignoring the css files in the prettier hook).

After the import of prettier config for JS and a rebase, the only change left in the branch is the output.css file. I agree about ignoring cCSSfiles, and it lleftus nothing to merge. I'm closing the PR.

@ulgens ulgens closed this Dec 28, 2024
@ulgens ulgens deleted the prettier-tuning branch December 28, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants