Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Error out when trying to compile with MSVC #11148

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

david-cortes
Copy link
Contributor

ref #9810
ref #11145

This PR makes it throw a compilation error with a clear message when a user tries to build the R package with the MSVC compiler. Hopefully this should save users some headaches as they'd otherwise run into runtime segfaults if the package gets compiled with MSVC.

@trivialfis
Copy link
Member

The error looks good, but did you compile the R package with MSVC successfully? With the latest R, I couldn't compile the package at all with MSVC being confused by R's header files.

@david-cortes
Copy link
Contributor Author

The error looks good, but did you compile the R package with MSVC successfully? With the latest R, I couldn't compile the package at all with MSVC being confused by R's header files.

I haven't tried compiling with MSVC. It fails due to other reasons before reaching the compilation stage.

@trivialfis
Copy link
Member

It fails due to other reasons before reaching the compilation stage.

Somehow feels right.

I revised the CMake script for R a few years ago and got it running on the CI with an old R version. I think it's time for us to move away from that now. I couldn't get MSVC to work with the latest R.

@trivialfis trivialfis merged commit 7f1add8 into dmlc:master Jan 7, 2025
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants