directly support ubuntu based distros in add repository snippet #21749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default to VERSION_CODENAME but use UBUNTU_CODENAME if present and remove comment to do so manually
github-actions
bot
added
area/engine
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thaJeztah
reviewed
Jan 9, 2025
There was a problem hiding this comment.
not sure; still on the fence on this. We don't test on any of these derivatives, which is why we added a section about this; https://docs.docker.com/engine/install/#other-linux-distributions
trying to make it "just work" without the user acknowledging / realizing it's an unsupported setup may make it seem as if it's supported / tested.
@vvoland @tianon @neersighted any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default to
VERSION_CODENAMEbut useUBUNTU_CODENAMEif present and remove comment to do so manuallyDescription
The note, that was added in the documentation to use
UBUNTU_CODENAMEinstead ofVERSION_CODENAMEcould easily be implemented in the snippet directly, by using shell parameter expansion with a default value. In caseUBUNTU_CODENAMEis present in/etc/os-releaseit is used and otherwise the regularVERSION_CODENAME.