Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputCommon: Make SDL Motor L/R Outputs not fight each other and support trigger rumble. #13296

Merged
merged 2 commits into from
Jan 26, 2025
Merged

InputCommon: Make SDL Motor L/R Outputs not fight each other and support trigger rumble. #13296

merged 2 commits into from
Jan 26, 2025
+67 −15

Conversation

jordan-woyak
Copy link
Member

@jordan-woyak jordan-woyak commented Jan 22, 2025 •
edited
Loading

Motor L would disable Motor R and vice versa, making a config like`Motor L` | `Motor R` ultimately only activate Motor R.

This fixes that.

Also added support for trigger rumble motors (mainly for Xbox One controllers).

@jordan-woyak jordan-woyak changed the title InputCommon: Make SDL Motor L/R Outputs not fight each other. InputCommon: Make SDL Motor L/R Outputs not fight each other and support trigger rumble. Jan 22, 2025
iwubcode
iwubcode approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM. Untested.

dreamsyntax
dreamsyntax approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using Motor L | Motor R and had no idea it was broken. Upon using your PR its extremely obvious. Tested on a Dual Sense and a Series controller.

mbc07
mbc07 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@mbc07 mbc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with a DualSense and a DualShock 4 on Windows...

@JosJuice JosJuice merged commit e29e0cd into dolphin-emu:master Jan 26, 2025
13 checks passed
@jordan-woyak jordan-woyak deleted the sdl-motor-lr branch January 26, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

@dreamsyntax dreamsyntax dreamsyntax approved these changes

@mbc07 mbc07 mbc07 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jordan-woyak @mbc07 @dreamsyntax @iwubcode @JosJuice