Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix role access descriptions in authorization documentation #34533

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix role access descriptions in authorization documentation #34533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions aspnetcore/security/authorization/roles.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ Access to an action can be limited by applying additional role authorization att

In the preceding `ControlAllPanelController` controller:

* Members of the `Administrator` role or the `PowerUser` role can access the controller and the `ShutDown` action.
* Only members of the `Administrator` role can access the `SetTime` action.
* Members of the `Administrator` role or the `PowerUser` role can access the controller and the `SetTime` action.
* Only members of the `Administrator` role can access the `ShutDown` action.
Comment on lines +62 to +63
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a screenshot of the current docs page (https://learn.microsoft.com/en-us/aspnet/core/security/authorization/roles?view=aspnetcore-9.0#adding-role-checks), because this might be easier to review.

image


A controller can be secured but allow anonymous, unauthenticated access to individual actions:

Expand Down Expand Up @@ -138,8 +138,8 @@ If multiple attributes are applied at the controller and action levels, ***all**

In the preceding `ControlAllPanelController` controller:

* Members of the `Administrator` role or the `PowerUser` role can access the controller and the `SetTime` action.
* Only members of the `Administrator` role can access the `ShutDown` action.
* Members of the `Administrator` role can access the controller and the `SetTime` action.
* Only members of the `Administrator` **and** the `PowerUser` role can access the `ShutDown` action.
Comment on lines +141 to +142
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a screenshot of the current docs page (https://learn.microsoft.com/en-us/aspnet/core/security/authorization/roles?view=aspnetcore-5.0#adding-role-checks-1), because this might be easier to review.

image


You can also lock down a controller but allow anonymous, unauthenticated access to individual actions.

Expand Down
Loading