-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move MapOpenApi() Inside the IsDevelopment() block for consistency wi… #34541
Open
davepcallan
wants to merge
4
commits into
dotnet:main
Choose a base branch
from
davepcallan:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−16
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d91968b
Move MapOpenApi() Inside the IsDevelopment() block for consistency wi…
davepcallan 70123d0
Conditionally map all calls to OpenApi in development environment
wadepickett 1664eaa
Combined MapOpenAPI and MapScalar in same env condition
wadepickett aabdd2a
Updated code highlight
wadepickett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,6 @@ | |
//#define DOCUMENTtransformer1 | ||
//#define DOCUMENTtransformer2 | ||
#define DOCUMENTtransformerUse999 | ||
//#define DEFAULT | ||
//#define FIRST | ||
//#define OPENAPIWITHSCALAR | ||
//#define MAPOPENAPIWITHCACHING | ||
|
@@ -80,7 +79,10 @@ internal record WeatherForecast(DateTime Date, int TemperatureC, string? Summary | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
if (app.Environment.IsDevelopment()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added Development environment condition for all calls to app.MapOpenAPI() and tested each. |
||
{ | ||
app.MapOpenApi(); | ||
} | ||
|
||
app.MapGet("/", () => "Hello world!"); | ||
|
||
|
@@ -107,7 +109,10 @@ internal record WeatherForecast(DateTime Date, int TemperatureC, string? Summary | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi(); | ||
} | ||
|
||
app.MapGet("/", () => "Hello world!"); | ||
|
||
|
@@ -161,7 +166,10 @@ public async Task TransformAsync(OpenApiDocument document, OpenApiDocumentTransf | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi(); | ||
} | ||
|
||
app.MapGet("/", () => "Hello world!"); | ||
|
||
|
@@ -189,7 +197,10 @@ public async Task TransformAsync(OpenApiDocument document, OpenApiDocumentTransf | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi(); | ||
} | ||
|
||
app.MapGet("/world", () => "Hello world!") | ||
.WithGroupName("internal"); | ||
|
@@ -253,7 +264,10 @@ public async Task TransformAsync(OpenApiDocument document, OpenApiDocumentTransf | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi(); | ||
} | ||
|
||
app.MapGet("/", () => new Body { Amount = 1.1m }); | ||
|
||
|
@@ -279,9 +293,10 @@ public class Body { | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi(); | ||
|
||
app.UseSwaggerUI(options => | ||
{ | ||
options.SwaggerEndpoint("/openapi/v1.json", "v1"); | ||
|
@@ -342,8 +357,11 @@ public class Body { | |
|
||
app.UseOutputCache(); | ||
|
||
app.MapOpenApi() | ||
.CacheOutput(); | ||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi() | ||
.CacheOutput(); | ||
} | ||
|
||
app.MapGet("/", () => "Hello world!"); | ||
|
||
|
@@ -365,10 +383,9 @@ public class Body { | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
|
||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi(); | ||
app.MapScalarApiReference(); | ||
} | ||
|
||
|
@@ -386,7 +403,10 @@ public class Body { | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi(); | ||
} | ||
|
||
app.MapGet("/", () => "Hello world!"); | ||
|
||
|
@@ -419,7 +439,10 @@ public class Body { | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi(); | ||
} | ||
|
||
app.MapGet("/", () => "Hello world!"); | ||
|
||
|
@@ -473,7 +496,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext | |
|
||
var app = builder.Build(); | ||
|
||
app.MapOpenApi(); | ||
if (app.Environment.IsDevelopment()) | ||
{ | ||
app.MapOpenApi(); | ||
} | ||
|
||
app.MapGet("/", () => "Hello world!"); | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed dupe preprocessor directive for default.