Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.13 to main #18214

Merged
merged 76 commits into from
Jan 9, 2025
Merged

Merge release/dev17.13 to main #18214

merged 76 commits into from
Jan 9, 2025

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from release/dev17.13 into main.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.13-to-main
git reset --hard upstream/main
git merge upstream/release/dev17.13
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.13-to-main --force

vzarytovskii and others added 30 commits October 8, 2024 14:46
…ase/dev17.13

Merge release/dev17.12 to release/dev17.13
…ase/dev17.13

Merge release/dev17.12 to release/dev17.13
…ase/dev17.13

Merge release/dev17.12 to release/dev17.13
… Build ID 2567162 (#17912)

* Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 2567162

* Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 2567162
vzarytovskii and others added 13 commits December 9, 2024 14:27
* Backport :: Bugfix :: Support `ldelem.u8`, `ldelem.u` opcode aliases (#18081) (#18096)

* Streamlining test deps a bit (#18022)

* Streamlining test deps a bit

* up

* Format ILVerify output a bit (#18120)

* fix for race condition in FileIndex.fileIndexOfFile (#18008)

* fix for race condition in FileIndex.fileIndexOfFile

* fantomas

* fixed ilverify baselines (just a single line number changed)

* add release notes entry

* FileToIndex: Added unlocked read so that lock is entered for new files only

* update ilverify baselines (changed line numbers only)

* Fix ILVerify

---------

Co-authored-by: Petr <[email protected]>
Co-authored-by: Vlad Zarytovskii <[email protected]>

* Update F# build version to 200

* Fix how much is trimmed from an interp string part (#18123)

* Fix how much is trimmed from an interp string part

Only trim last 2 characters if they are "%s" and the '%' is not escaped

* Add release note

---------

Co-authored-by: Adam Boniecki <[email protected]>

* Sink: report SynPat.ArrayOrList type (#18127)

---------

Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Petr <[email protected]>
Co-authored-by: Martin <[email protected]>
Co-authored-by: Vlad Zarytovskii <[email protected]>
Co-authored-by: Adam Boniecki <[email protected]>
Co-authored-by: Adam Boniecki <[email protected]>
Co-authored-by: Alex Berezhnykh <[email protected]>
Co-authored-by: Kevin Ransom (msft) <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 8, 2025

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@psfinaki psfinaki added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jan 8, 2025
psfinaki
psfinaki previously approved these changes Jan 8, 2025
@psfinaki psfinaki enabled auto-merge (squash) January 8, 2025 13:38
Copy link
Contributor

@0101 0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so what's happening here? It's merging back all the merges. And the net difference is that compiler translations were confirmed and editor ones were undone 🤔

@psfinaki psfinaki disabled auto-merge January 8, 2025 14:28
@psfinaki
Copy link
Member

psfinaki commented Jan 8, 2025

Damn I thought it's a merge to the release branch, didn't look properly enough.

@vzarytovskii
Copy link
Member

vzarytovskii commented Jan 9, 2025

Hmm, so what's happening here? It's merging back all the merges. And the net difference is that compiler translations were confirmed and editor ones were undone 🤔

This is more or less normal, means two things

  1. 17.13 has something main doesnt (translations, which checks out, since translations target was 17.13)
  2. Bot hasn't created a back merge from 17.13 to main since its config was changed.

This needs to go to main. Same thing happened to 17.12 before - #17842

@0101 0101 merged commit 88463f8 into main Jan 9, 2025
33 of 34 checks passed
@0101 0101 deleted the merges/release/dev17.13-to-main branch January 9, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure auto-merge NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants