Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollView's ScrollToAsync doesn't complete when called thrice with the same value #27300

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KarthikRajaKalaimani
Copy link
Contributor

@KarthikRajaKalaimani KarthikRajaKalaimani commented Jan 23, 2025

Issue Details:

When calling ScrollToAsync thrice with the same Y value on a ScrollView, the scrolling operation does not complete on iOS, Windows, and Catalyst platforms. This behavior is inconsistent with Android, where the scrolling operation completes as expected.

Root Cause:

The ScrollToAsync method does not mark the task as completed because the scroll did not occur due to the target position already being the current position. As a result, the ScrollToAsync method does not return control to the calling method.

Description of Change:

To resolve the issue, i called the ScrollFinished method if the target scroll position and current scroll position is same because the ScrollFinished method will mark the task as completed.

Tested the behavior in the following platforms.

- [x] Android

- [x] Windows

- [x] iOS

- [x] Mac

Regarding Test Case :

I will enable the test case of this issue once the this PR is merged.

Reference:

N/A

Issues Fixed:

Fixes #27250

Screenshots

Before After
Before_27250.mov
After_27250.mov

…with the same value

Fixed ScrollView's ScrollToAsync doesn't complete when called thrice with the same value.
ScrollView's ScrollToAsync doesn't complete when called thrice with the same value
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 23, 2025
Copy link
Contributor

Hey there @KarthikRajaKalaimani! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@KarthikRajaKalaimani
Copy link
Contributor Author

@dotnet-policy-service agree company="Syncfusion, Inc."

@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 24, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-scrollview ScrollView community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScrollView's ScrollToAsync doesn't complete when called thrice with the same value
3 participants