Fix: Set DOTNET_ROOT to DOTNET_ROOT_USER during test execution #76819
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
dibarbet
approved these changes
Jan 21, 2025
dibarbet
reviewed
Jan 22, 2025
| @@ -58,7 +58,7 @@ public async Task<RunTestsPartialResult[]> HandleRequestAsync(RunTestsParams req | |||
| EnvironmentVariables = new() | |||
| { | |||
| // Reset dotnet root so that vs test console can find the right runtimes. | |||
| { DotnetCliHelper.DotnetRootEnvVar, string.Empty }, | |||
| { DotnetCliHelper.DotnetRootEnvVar, Environment.GetEnvironmentVariable("DOTNET_ROOT_USER") }, | |||
There was a problem hiding this comment.
One thing actually - we should only set this to DOTNET_ROOT_USER if it isn't EMPTY - https://github.com/dotnet/vscode-csharp/blob/main/src/lsptoolshost/dotnetRuntimeExtensionResolver.ts#L83C60-L83C65
Otherwise we'll be putting an invalid value in DOTNET_ROOT_USER
There was a problem hiding this comment.
You're right! I've also added an additional check using string.IsNullOrEmpty(Environment.GetEnvironmentVariable("DOTNET_ROOT_USER")). Is this approach fine, or would you prefer we remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue where the
DOTNET_ROOTenvironment variable is set to an empty string during test execution, leading to failures when running external processes.Related to dotnet/vscode-csharp#6295