Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logger param in CodeModel create #76840

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

arunchndr
Copy link
Member

No description provided.

@arunchndr arunchndr requested a review from a team as a code owner January 21, 2025 21:39
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 21, 2025
@@ -40,7 +40,7 @@ public sealed partial class FileCodeModel : AbstractCodeModelObject, EnvDTE.File
ITextManagerAdapter textManagerAdapter)
{
// Keep track that code model was accessed. We want to get a sense of how widespread usage of it still is.
Logger.Log(FunctionId.CodeModel_FileCodeModel_Create);
Logger.Log(FunctionId.CodeModel_FileCodeModel_Create, logLevel: RoslynLog.LogLevel.Information);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot tell you the history, but only loglevel of information or higher gets logged to telemetry, see https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/Core/Def/Telemetry/Shared/TelemetryLogger.cs#L166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants