Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove source generator diagnostic reporting from Workspace #76863

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

CyrusNajmabadi
Copy link
Member

Draft while we decide the future of SG diagnostics (and whether they should be reported by analyzers instead).

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner January 22, 2025 17:43
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 22, 2025
@CyrusNajmabadi CyrusNajmabadi marked this pull request as draft January 22, 2025 17:43
@davidwengier
Copy link
Contributor

davidwengier commented Jan 23, 2025

Haven't looked at the changes, but would this prevent LSP requests for document diagnostics being returned for source generated files?

If so, the Razor compiler will definitely need to follow up (and maybe they already know that 🤷‍♂️)

/cc @chsienki @jaredpar

@CyrusNajmabadi
Copy link
Member Author

Haven't looked at the changes, but would this prevent LSP requests for document diagnostics being returned for source generated files?

Quite possibly. I thought razor bypassed all this stuff anyways. You guys just grab the raw RunResult i thought :)

@CyrusNajmabadi
Copy link
Member Author

@davidwengier we'd def have to work together on this IF we decide on going this direction. We are not sure if we will, this was just an initial forway into this space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants