Move merging of partial members to an earlier phase of members construction. #76871
+277
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uction. Fixes dotnet#76651. Fixes dotnet#75002. Related to dotnet#76842. Related to dotnet#76870.
dotnet-issue-labeler
bot
added
the
untriaged
This was referenced Jan 22, 2025
|
@RikkiGibson, @cston, @dotnet/roslyn-compiler Please review |
|
@jjonescz, FYI |
jcouv
reviewed
Jan 24, 2025
| } | ||
| } | ||
|
|
||
| void mergePartialMethods(ArrayBuilder<Symbol> nonTypeMembers, SourceOrdinaryMethodSymbol currentMethod, SourceOrdinaryMethodSymbol prevMethod, BindingDiagnosticBag diagnostics) |
There was a problem hiding this comment.
static?
I do not think I changed anything that affects ability to place the modifier on the method. Therefore, I won't try adding it, unless there is other feedback to take care of.
There was a problem hiding this comment.
Scratch that, it looks like I removed DuplicateMembersByNameIfCached call
There was a problem hiding this comment.
It looks like the containing method MergePartialMembers could be marked static too
jcouv
reviewed
Jan 24, 2025
| } | ||
| } | ||
|
|
||
| void mergePartialProperties(ref Dictionary<ReadOnlyMemory<char>, ImmutableArray<Symbol>> membersByName, ReadOnlyMemory<char> name, SourcePropertySymbol currentProperty, SourcePropertySymbol prevProperty, BindingDiagnosticBag diagnostics) | ||
| void mergePartialProperties(ArrayBuilder<Symbol> nonTypeMembers, SourcePropertySymbol currentProperty, SourcePropertySymbol prevProperty, BindingDiagnosticBag diagnostics) |
There was a problem hiding this comment.
static?
Same response
|
@RikkiGibson, @cston, @dotnet/roslyn-compiler For the second review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76651.
Fixes #75002.
Related to #76842.
Related to #76870.