Update runtime async spec #76872
Open
Update runtime async spec #76872
+296
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates from the runtime side: dotnet/runtime#110420.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@jcouv @jakobbotsch @VSadov @agocke, this is the expected Roslyn code-gen side of the intrinsic method await version. Please give it a look! |
jcouv
reviewed
Jan 22, 2025
jcouv
previously approved these changes
Jan 22, 2025
jakobbotsch
reviewed
Jan 23, 2025
jakobbotsch
reviewed
Jan 23, 2025
jakobbotsch
reviewed
Jan 23, 2025
333fred
commented
Jan 23, 2025
| Translated C#: | ||
|
|
||
| ```cs | ||
| System.Runtime.CompilerServices.RuntimeHelpers.Await(C.M<Task>()); |
There was a problem hiding this comment.
@jakobbotsch @VSadov is it going to complicate the JIT's pattern matching significantly if we use this approach for generic methods like this? In the old specialized call version, we would have needed go to through UnsafeAwaitAwaiterFromRuntimeAsync, but since this now just appears to be Task-returning method, I'm hoping we can keep IL size down and just call Await.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from the runtime side: dotnet/runtime#110420.