Bump BCL references to 9.0 #76890
Bump BCL references to 9.0 #76890
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
| @@ -27,6 +27,8 @@ | |||
| The version targeted is only used for build time, since we use MSBuildLocator to discover the proper version at runtime. | |||
| --> | |||
| <_MsbuildVersion>17.3.4</_MsbuildVersion> | |||
| <!-- S.C.I 9.0 no longer supports .NET 6 --> | |||
| <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> | |||
There was a problem hiding this comment.
@jasonmalinowski Would we want to pin the BuildHost at S.C.I 8.0.0 until we are ready to bump the tfm?
There was a problem hiding this comment.
Generally we should be bumping the BuildHost TFM "as late as possible". Once we merge the other PR that makes the library netstandard2.0, somebody could theoretically try to use MSBuildWorkspace in a 6.0 app...but if the BuildHost only runs on 8.0 or later you end up creating an implicit version limitation there.
That is of course not to say that we should bend backwards to support older versions -- but if we can do a minimal amount of work to keep stuff older, that might be easier than dealing the inevitable bugs people file when old versions don't work.
I think setting this property seems easiest; frankly I'm kinda surprised we added such a property in the first place. I'd propose changing the comment though since I'm sure other package upgrades will depend on this than just System.Collections.Immutable.
There was a problem hiding this comment.
And oh: I imagine this is easier to set this than it is to pin versions and deal with the special problems that creates.
There was a problem hiding this comment.
ah ok, I was afraid the package wasn't shipping with netstandard or net6.0 builds but it still has netstardard2.0
| @@ -27,6 +27,8 @@ | |||
| The version targeted is only used for build time, since we use MSBuildLocator to discover the proper version at runtime. | |||
| --> | |||
| <_MsbuildVersion>17.3.4</_MsbuildVersion> | |||
| <!-- S.C.I 9.0 no longer supports .NET 6 --> | |||
There was a problem hiding this comment.
| <!-- S.C.I 9.0 no longer supports .NET 6 --> | |
| <!-- Some of the 9.0 packages no longer have been tested against .NET 6, but we're OK with that --> |
| <!-- Pin SCI to 8.0, since this generator is built & consumed in our pipeline so it has to work with stock compiler in msbuild (currently shipped with SCI 8.0) --> | ||
| <PackageReference Include="System.Collections.Immutable" VersionOverride="8.0.0" PrivateAssets="All" /> |
There was a problem hiding this comment.
| <!-- Pin SCI to 8.0, since this generator is built & consumed in our pipeline so it has to work with stock compiler in msbuild (currently shipped with SCI 8.0) --> | |
| <PackageReference Include="System.Collections.Immutable" VersionOverride="8.0.0" PrivateAssets="All" /> | |
| <!-- Pin SRM & SCI to 8.0, since this generator is built & consumed in our pipeline so it has to work with stock compiler in msbuild (currently shipped with SRM & SCI 8.0) --> | |
| <PackageReference Include="System.Reflection.Metadata" VersionOverride="8.0.0" PrivateAssets="All" /> | |
| <PackageReference Include="System.Collections.Immutable" VersionOverride="8.0.0" PrivateAssets="All" /> |
No description provided.