Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Delete IL verification failure helpers in importer #108996

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

amanasifkhalid
Copy link
Member

Part of #32648. Per this comment, I suspect this is the next (last?) step in removing IL verifier from the importer.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 17, 2024
@amanasifkhalid
Copy link
Member Author

cc @dotnet/jit-contrib -- are there any CI legs worth running for this?

@AndyAyersMS
Copy link
Member

I suspect this is the next (last?) step in removing IL verifier from the importer.

We might want to do some renaming, say verCurrentState -> stackState or something. And there are various comments that could be updated/removed.

cc @dotnet/jit-contrib -- are there any CI legs worth running for this?

I don't think so; no diffs should be sufficient.

Our SPMI collection set is a bit impoverished right now, so maybe wait until that's fixed and rerun?

@amanasifkhalid
Copy link
Member Author

Our SPMI collection set is a bit impoverished right now, so maybe wait until that's fixed and rerun?

Sure; I'll get the renaming out of the way in the meantime.

@amanasifkhalid
Copy link
Member Author

Our SPMI collection set is a bit impoverished right now, so maybe wait until that's fixed and rerun?

Not sure when this will be resolved, so I thought I'd push my revisions now for review.

Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

@amanasifkhalid
Copy link
Member Author

/ba-g CLR_Tools_Tests pipeline is timing out across PRs.

@amanasifkhalid amanasifkhalid merged commit 2bb4bb7 into dotnet:main Nov 4, 2024
116 of 118 checks passed
@amanasifkhalid amanasifkhalid deleted the delete-ilverify branch November 4, 2024 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants