Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPMI: Use Helix work directory for SPMI download #109367

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

jakobbotsch
Copy link
Member

The correlation payload directory can have collections left over from other workitems.

For example, the windows-x64 superpmi-diffs run at https://dev.azure.com/dnceng-public/public/_build/results?buildId=856222&view=ms.vss-build-web.run-extensions-tab ran over smoke_tests multiple times because a previous work item had already downloaded that collection.

The correlation payload directory can have collections left over from
other workitems.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 30, 2024
@jakobbotsch
Copy link
Member Author

@jakobbotsch jakobbotsch marked this pull request as ready for review October 30, 2024 15:21
@jakobbotsch jakobbotsch requested a review from a team October 30, 2024 15:21
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakobbotsch jakobbotsch merged commit f11dfc9 into dotnet:main Oct 30, 2024
88 checks passed
@jakobbotsch jakobbotsch deleted the superpmi-diffs-workdir branch October 30, 2024 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants