JIT: Don't convert unreachable BBJ_CALLFINALLYRET blocks to BBJ_THROW during morph
#109519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
/azp run Antigen |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Open
3 tasks
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Antigen run didn't find anything new. No diffs. Thanks! |
AndyAyersMS
approved these changes
Nov 5, 2024
|
/ba-g macOS pipelines blocked by deprecated images |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #109514. Fix #109515. Follow-up to #109394. Converting
BBJ_CALLFINALLYRETblocks toBBJ_THROWwithout considering the block's correspondingBBJ_CALLFINALLYblock breaks flowgraph invariants. The simplest solution seems to be to not convert such blocks toBBJ_THROW, and let early flowgraph opts convert the call-finally pair into a retlessBBJ_CALLFINALLY.