[release/9.0-staging] Fix C++/CLI applications which use __declspec(appdomain) #110495
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…bly in use. This avoids possible recursive loading issues found in C++/CLI codebases. Repurpose the NativeCallingManaged test to subsume this particular regression test case. Fix #110365
|
Tagging subscribers to this area: @dotnet/interop-contrib |
jkoritzinsky
approved these changes
Dec 6, 2024
AaronRobinsonMSFT
approved these changes
Dec 7, 2024
This was referenced Dec 7, 2024
jeffschwMSFT
approved these changes
Jan 8, 2025
jeffschwMSFT
added
Servicing-approved
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110367 to release/9.0-staging
/cc @davidwrighton
Customer Impact
See issue #110365. Essentially this broke a customer which had C++/CLI existing code which explicitly specified that a particular variable should be given appdomain lifetime. It also requires running a debug build of the C++/CLI code.
Regression
This was introduced in .NET 9 as part of the statics rewrite.
Testing
A new test covering this specific scenario was added to the test suite. It was not found earlier due to a lack of an extensive C++/CLI test suite being available, and what limited testing that happened did not happen to cover this scenario.
Risk
Low risk. The fix simply defers statics intialization to a somewhat later time. This deferral is what normally happens for static variables, and is only not deferred in cases where we want the static variables visible to the debugger, so adding another case which will defer the static variable will have a very small impact on the view of this data in the debugger.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.