-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 'ConditionalWeakTable<TKey,TValue>.GetOrAdd' APIs #111204
base: main
Are you sure you want to change the base?
Implement 'ConditionalWeakTable<TKey,TValue>.GetOrAdd' APIs #111204
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
...libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/ConditionalWeakTable.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/libraries/System.Runtime/ref/System.Runtime.cs: Evaluated as low risk
...libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/ConditionalWeakTable.cs
Show resolved
Hide resolved
...libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/ConditionalWeakTable.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/ConditionalWeakTable.cs
Outdated
Show resolved
Hide resolved
Go over Corelib and maybe other core assemblies and switch them to use the new API where appropriate? There are not that many candidates. |
I've gone over uses I could find of the now hidden methods and replaced them. Particularly happy with how |
Closes #89002
This PR implements the new APIs for
ConditionalWeakTable<TKey, TValue>
and hides some legacy ones: