Adding several new tests, add reference support, fixing additional ar… #11
Conversation
src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTests.cs
Outdated
Show resolved
Hide resolved
…e traits for tests, and downlevel traits
|
So, it looks like all the tests are failing because it's actually running the tests I have here.... and that includes the downlevel tests. Apparently, .Net6 and .Net7 aren't on the test machine, so it breaks. |
|
@mattscheffer We can change around the global json so that it installs the downlevel runtimes. I'll work on that. |
src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTests.cs
Outdated
Show resolved
Hide resolved
| @@ -35,7 +35,7 @@ public void VerifyConsoleTemplate(DotNetLanguage language) | |||
| [Theory] | |||
| [MemberData(nameof(GetLanguages))] | |||
| [Trait("Category", "Offline")] | |||
| public void VerifyOfflineConsoleTemplate(DotNetLanguage language) | |||
| public void VerifyConsoleTemplate(DotNetLanguage language) | |||
| { | |||
| var newTest = new SdkTemplateTest( | |||
| nameof(SdkTemplateTests) + "Offline", language, _scenarioTestInput.TargetRid, DotNetSdkTemplate.Console, | |||
There was a problem hiding this comment.
"nameof(SdkTemplateTests) + "Offline" should be refactored accordingly as well.
There was a problem hiding this comment.
Ack. Yes it should be.
There was a problem hiding this comment.
Fixed in latest commit
|
@mmitche It doesn't look like your fix worked. The test machines have failures at the same point. https://dev.azure.com/dnceng-public/public/_build/results?buildId=382650&view=results |
Looking. |
|
@mattscheffer I did some poking around. Installing the downlevel runtimes will not enable downlevel targeting when using On the other hand, multi-targeting in general would work. So if you had an existing console app targeting net7, and the code actually works on net6, enabling an additional net6 TargetFramework should work. |
@mmitche Gotcha, I was under the impression from the scenario list that this first bit was want we wanted but I can see it being out of scope, as we only care about the 1 scenario. Do you want me to remove/comment these tests right now for this check in? Or wait to check in until multitfm is added. I'm good either way. |
|
I would comment those tests for now. |
|
Ok. Looking at the new failures. Looks like we need the skip based on platform already. WPF doesn't work at all on Linux/Mac which is causing the majority of the failures. I'll start working on that. |
| @@ -0,0 +1,29 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
There was a problem hiding this comment.
I would move this into the Common dir.
There was a problem hiding this comment.
Moved in latest commit.
| using System.Runtime.InteropServices; | ||
| using System.Collections.Immutable; | ||
| using Microsoft.DotNet.ScenarioTests.SdkTemplateTests; |
There was a problem hiding this comment.
This shouldn't be necessary if you move the OperatingSystemFinder in here.
src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/OperatingSystemFinder.cs
Outdated
Show resolved
Hide resolved
…. Fixing bug that doesn't allow OSPlatform.Windows to be picked
|
@mmitche Can you merge? I don't have access to do so. |
…guments