Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest jdk available in VMR aspnetcore build #45822

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jan 9, 2025

All VMR and aspnetcore repos builds are currently broken

Our build images got updated yesterday and with that, the installed jdk versions changed significantly (across major versions). This broke aspnetcore's build which asserts on a very specific version.

I reached out to @wtgodbe in dotnet/aspnetcore#58465 (comment) to better understand why they had to change back to a an exact version match instead of just depending on a specific major version.

This patch tries to use whatever latest version is available by using "latest". Let's see if that works.

@ViktorHofer ViktorHofer requested review from a team as code owners January 9, 2025 08:01
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 9, 2025
@ViktorHofer
Copy link
Member Author

OK that didn't work:

    EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\core\signalr.client.java.core.javaproj]
    EXEC : error : [options] target value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\core\signalr.client.java.core.javaproj]
    EXEC : error : [options] To suppress warnings about obsolete options, use -Xlint:-options. [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\core\signalr.client.java.core.javaproj]
    EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\core\signalr.client.java.core.javaproj]
    EXEC : error : [options] target value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\core\signalr.client.java.core.javaproj]
    EXEC : error : [options] To suppress warnings about obsolete options, use -Xlint:-options. [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\core\signalr.client.java.core.javaproj]
    EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\messagepack\signalr.client.java.messagepack.javaproj]
    EXEC : error : [options] target value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\messagepack\signalr.client.java.messagepack.javaproj]
    EXEC : error : [options] To suppress warnings about obsolete options, use -Xlint:-options. [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\messagepack\signalr.client.java.messagepack.javaproj]
    EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\messagepack\signalr.client.java.messagepack.javaproj]
    EXEC : error : [options] target value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\messagepack\signalr.client.java.messagepack.javaproj]
    EXEC : error : [options] To suppress warnings about obsolete options, use -Xlint:-options. [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\messagepack\signalr.client.java.messagepack.javaproj]
    EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\messagepack\signalr.client.java.messagepack.javaproj]
    EXEC : error : [options] target value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\messagepack\signalr.client.java.messagepack.javaproj]
    EXEC : error : [options] To suppress warnings about obsolete options, use -Xlint:-options. [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\messagepack\signalr.client.java.messagepack.javaproj]
    EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\test\signalr.client.java.Tests.javaproj]
    EXEC : error : [options] target value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\test\signalr.client.java.Tests.javaproj]
    EXEC : error : [options] To suppress warnings about obsolete options, use -Xlint:-options. [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\test\signalr.client.java.Tests.javaproj]
    EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\test\signalr.client.java.Tests.javaproj]
    EXEC : error : [options] target value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\test\signalr.client.java.Tests.javaproj]
    EXEC : error : [options] To suppress warnings about obsolete options, use -Xlint:-options. [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\test\signalr.client.java.Tests.javaproj]
        0 Warning(s)
        21 Error(s)

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jan 9, 2025

OK the patch works in dotnet/aspnetcore#59788. I will wait until the sync is complete and then fast merge to unblock the broken builds.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 9, 2025

dotnet/aspnetcore#59794 - I'm in favor of running init-tools-native in CI as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants