-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest jdk available in VMR aspnetcore build #45822
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Request triage from a team member
labels
Jan 9, 2025
akoeplinger
approved these changes
Jan 9, 2025
This was referenced Jan 9, 2025
OK that didn't work:
|
OK the patch works in dotnet/aspnetcore#59788. I will wait until the sync is complete and then fast merge to unblock the broken builds. |
This was referenced Jan 9, 2025
dotnet/aspnetcore#59794 - I'm in favor of running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All VMR and aspnetcore repos builds are currently broken
Our build images got updated yesterday and with that, the installed jdk versions changed significantly (across major versions). This broke aspnetcore's build which asserts on a very specific version.
I reached out to @wtgodbe in dotnet/aspnetcore#58465 (comment) to better understand why they had to change back to a an exact version match instead of just depending on a specific major version.
This patch tries to use whatever latest version is available by using "latest". Let's see if that works.