Improve xml comments review 5th DRAFT #12148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul1956
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12148 +/- ##
====================================================
+ Coverage 76.14673% 97.03456% +20.88782%
====================================================
Files 3191 1200 -1991
Lines 640105 358395 -281710
Branches 47233 5592 -41641
====================================================
- Hits 487419 347767 -139652
+ Misses 149166 9817 -139349
+ Partials 3520 811 -2709
Flags with carried forward coverage won't be shown. Click here to find out more. |
paul1956
changed the title
This was referenced Sep 26, 2024
| ''' <exception cref="NotSupportedException">A folder name in the path contains a colon (:) or is in an invalid format.</exception> | ||
| ''' <exception cref="SecurityException">The user lacks necessary permissions to view the path.</exception> | ||
| ''' <exception cref="UnauthorizedAccessException">A destination file exists but cannot be accessed.</exception> | ||
| Public Sub CopyDirectory(sourceDirectoryName As String, destinationDirectoryName As String, overwrite As Boolean) |
There was a problem hiding this comment.
Perhaps this comment can reference docs for the SYstem.IO API via the inheritdocs tag?
There was a problem hiding this comment.
@Tanya-Solyanik i can fix comment but this is not ready to be reviewed (it should be DRAFT) as it includes all the other small PR’s not yet merged.
There was a problem hiding this comment.
I have updated the VB Runtime Proxy Comments to use inheritdoc cref=""
Sometimes I could point to System.IO other files I had to point to FileIO.FileSystem because VB is not always a thin layer over System.IO, in some causes Sub and Function are swapped, return types are different or System.IO does not have all the overloads that VB has plus other similar reasons. The complexity/size of the files has been drastically simplified.
This is still not ready to review.
* Removing reference to ContextMenuStrip when dispose control * Merge 'main' to current branch * Detach ContextMenuStrip from control when executing Dispose * Use pattern matching for judge variable menu
* Update InitializeComponent() template * Removing extra namespace
…ties.All)] on PropertyGridView.cs (dotnet#12356)
add vs-feedback info to the readme
…StripComboBoxFlatComboAdapter (dotnet#12394) * Add code coverage for ToolStripComboBox.ToolStripComboBoxControl.ToolStripComboBoxFlatComboAdapter * Handle FeedBacks * Handle FeedBacks * Handle FeedBacks * Fixed the error * Remove failed test case
* Update dependencies from https://github.com/dotnet/runtime build 20241103.1 Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.ComponentModel.Composition , System.ComponentModel.Composition.Registration , System.Configuration.ConfigurationManager , System.Data.Odbc , System.Data.OleDb , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.DirectoryServices.AccountManagement , System.DirectoryServices.Protocols , System.Formats.Nrbf , System.IO.Hashing , System.IO.Packaging , System.IO.Ports , System.Management , System.Reflection.Context , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Runtime.Caching , System.Runtime.Serialization.Formatters , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceModel.Syndication , System.ServiceProcess.ServiceController , System.Speech , System.Text.Encoding.CodePages , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 From Version 10.0.0-alpha.1.24552.2 -> To Version 10.0.0-alpha.1.24553.1 * Update dependencies from https://github.com/dotnet/runtime build 20241104.9 Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.ComponentModel.Composition , System.ComponentModel.Composition.Registration , System.Configuration.ConfigurationManager , System.Data.Odbc , System.Data.OleDb , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.DirectoryServices.AccountManagement , System.DirectoryServices.Protocols , System.Formats.Nrbf , System.IO.Hashing , System.IO.Packaging , System.IO.Ports , System.Management , System.Reflection.Context , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Runtime.Caching , System.Runtime.Serialization.Formatters , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceModel.Syndication , System.ServiceProcess.ServiceController , System.Speech , System.Text.Encoding.CodePages , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 From Version 10.0.0-alpha.1.24552.2 -> To Version 10.0.0-alpha.1.24554.9 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Update dependencies from https://github.com/dotnet/arcade build 20241104.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.24551.1 -> To Version 10.0.0-beta.24554.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…dotnet#12418) Add tests for VB Application Services Exceptions and fix UserTests.UserIdentity to use Auto Properties to stop compiler from giving suggestion.
…-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…ML-Comments-Review-5th-DRAFT
…ML-Comments-Review-5th-DRAFT
…-after-FixIssue#9807-3rd
…Review-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…ML-Comments-Review-5th-DRAFT
…Review-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…Review-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…ML-Comments-Review-5th-DRAFT
…Review-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…ML-Comments-Review-5th-DRAFT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses improved XML comment in #11984
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow