-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container image build args can be overridden following their order of precedence #3000
Comments
com.google.common.collect.ImmutableMap
Hi @rohanKanojia , do you still need help on this issue ? |
@clarenced : Sorry for the late reply, yes it would be nice to get this issue addressed. However, I'm not sure if it's clear enough for you to pick up. I'll check and get back to you. |
@rohanKanojia I look at it this weekend and come later if have further questions :) |
@clarenced : Have you already started working on it? |
@rohanKanojia Not yet, I just read the discussions to have an idea. |
Hi @rohanKanojia, It's been a while, do you mind if I pick this up? |
@l3002 : 👋 hey, nice to have you back! Sure, you can try this. |
thanks @rohanKanojia. I'll get started with it. |
Hi @rohanKanojia, Have we decided the precedence of the sources over one another? Because I believe that the following order of precedence (from higher to lower) would be the best possible one for implementing this:
Let me know what you think about it. |
What's the reason for changing the order of precedence stated by Rohan in the description of the issue? I find it OK that project properties override system properties (although I'm not sure of the side effects especially with Gradle). |
Hi @manusa, I think precedence mentioned by Rohan is alright but I also think it would be better if project properties have a precedence over system properties as the user might want to declare more general args as env variables and project specific properties in project properties. I'm not sure about the side effects with build tools, though. I'll check for any anomalies or side effects and update. |
Component
JKube Kit
Description
Originally discussed in #2994 (comment)
Currently, JKube tries to discover Docker Build Args from the following sources:
~/.docker/config.json
At the moment BuildArgResolverUtil (introduced in #2994) throws an exception if the same keys are provided from different sources (mentioned above).
User's might want to override some of these build args on a single execution (for example while performing a single build from the command line).
To be able to allow for this, the behavior needs to be changed so that instead of throwing an exception in case of key collision, a warning is logged.
The proper order of precedence should be documented (and tested) too.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: