feat(jkube-kit-build-api): Added support for overriding Build Args appearing in multiple sources #3637
+136
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: l3002 <[email protected]>
Signed-off-by: l3002 <[email protected]>
Signed-off-by: l3002 <[email protected]>
Eclipse JKube CI ReportStarted new GH workflow run for #3637 (2025-01-23T05:09:05Z) ⚙️ JKube E2E Tests (12922546865)
|
|
Thanks, overall changes look good. Shall we also document the predence in the user facing docs: https://eclipse.dev/jkube/docs/kubernetes-maven-plugin/#_build_args You can find it's source here : _buildargs.adoc |
Yeah, I think I missed that. I'll push a commit for that as well. |
Signed-off-by: l3002 <[email protected]>
|
| properties which are not Docker https://docs.docker.com/engine/reference/builder/#arg[predefined] properties, the | ||
| The following order of precedence will be used for resolving Docker Build Args specified across multiple sources: | ||
|
|
||
| **System Properties** (highest precedence) > **Project Properties** > **Plugin Configuration** (lowest precedence) |
There was a problem hiding this comment.
Image Configuration has higher precedence than System properties, right?
There was a problem hiding this comment.
yeah, Image Configuration has higher precedence than System properties. I was considering adding this to the docs as well but then I saw that the docs address build args specified in properties. If you want I can add another image configuration to the valid sources and precedence order in the docs.
There was a problem hiding this comment.
Maybe you can specify in some sentence below that ImageConfiguration build args override all property values.
| JKubeConfiguration configuration, KitLogger logger) { | ||
| List<Map<String, String>> buildArgSources = new ArrayList<>(); | ||
|
|
||
| // Add build arg sources following order of precedence |
There was a problem hiding this comment.
Suggested change
| // Add build arg sources following order of precedence | |
| // Add build arg sources following increasing order of precedence |
rohanKanojia
approved these changes
Jan 29, 2025
|
Just minor comments otherwise looks good. Thanks a lot! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3000
The following changes were made to add support for overriding Build Args appearing in multiple sources:
Type of change
test, version modification, documentation, etc.)
Checklist