Add and fix warnings for various Helm goals #2772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- helm-lint and helm-push: Add warning when 'helm' goal is not ran - helm: Fix warning when 'resource' goal is not ran Signed-off-by: Jurrie Overgoor <[email protected]>
Eclipse JKube CI ReportStarted new GH workflow run for #2772 (2024-03-11T18:28:22Z) ⚙️ JKube E2E Tests (8229716200)
|
Signed-off-by: Jurrie Overgoor <[email protected]>
18 tasks
Signed-off-by: Jurrie Overgoor <[email protected]>
Jurrie
commented
Mar 6, 2024
jkube-kit/parent/pom.xml
Outdated
| @@ -736,6 +736,12 @@ | |||
| <version>${version.mockito}</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.mockito</groupId> | |||
| <artifactId>mockito-inline</artifactId> | |||
There was a problem hiding this comment.
Very strange that I needed this in OpenshiftHelmPushMojoTest for the org.mockito.Mockito.mockConstruction(HelmService.class); thingy, but HelmPushMojoTest doesn't need it...
There was a problem hiding this comment.
I think you can avoid this by adding mockito-inline folder in src/test/resources
There was a problem hiding this comment.
Wow, I never knew! Thanks for the tip! Implemented in e463ef7.
rohanKanojia
reviewed
Mar 6, 2024
...aven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/HelmLintMojo.java
Show resolved
Hide resolved
Signed-off-by: Jurrie Overgoor <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2772 +/- ##
=============================================
+ Coverage 59.36% 70.62% +11.26%
- Complexity 4586 5027 +441
=============================================
Files 500 486 -14
Lines 21211 19483 -1728
Branches 2830 2509 -321
=============================================
+ Hits 12591 13760 +1169
+ Misses 7370 4494 -2876
+ Partials 1250 1229 -21 ☔ View full report in Codecov by Sentry. |
|
Why have you deleted these tests? Were they breaking due to this refactor? |
Yes, due to the new check in HelmServiceUtil. This check results in no exception being thrown. The way I look at the deleted unit tests is that they were made after the code was made. It more or less just models what the code was doing, instead of what the intent was. I don't see why an exception should be thrown when there are no source files. And if there is a reason for it, why wasn't a dedicated exception, with explanatory name and proper description string used? But I could be wrong here! If the tests served a purpose, please describe that purpose and I'll see what I can do to put the tests back. |
Signed-off-by: Jurrie Overgoor <[email protected]>
|
rohanKanojia
approved these changes
Mar 12, 2024
|
@Jurrie : There is a minor conflict. Could you please address it whenever you revisit this PR? |
|
Hi Jurrie, thanks for looking into this. This is fine but it will need to be immediately refactored if merged as is. One approach can be to provide the necessary variables such as the kind of plugin (Maven or Gradle) and applicable name of the goal/task ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add and fix warnings for various Helm goals
Type of change
test, version modification, documentation, etc.)
Checklist