feat: update design tokens for tag #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justineo
requested changes
Jun 11, 2024
| @dls-tag-border-radius-s: @dls-border-radius-1; | ||
| @dls-tag-border-radius-m: @dls-border-radius-1; | ||
|
|
||
| @dls-tag-border-width: 1px; | ||
| @dls-tag-border-width-xs: 0.5px; |
There was a problem hiding this comment.
这里的逻辑是这样的，如果不同的 size 尺寸可能不一样，就得把 size 都枚举一遍，这里应该要 xs, s, m 都有。不带 size 后缀的可以保留来向前兼容。
| @dls-tag-padding: @dls-padding-unit * 2; | ||
| @dls-tag-padding-xs: @dls-padding-unit * 1; |
| @dls-tag-padding: @dls-padding-unit * 2; | ||
| @dls-tag-padding-xs: @dls-padding-unit * 1; | ||
| @dls-tag-prefix-icon-spacing: @dls-padding-unit * 1; |
There was a problem hiding this comment.
s, m 尺寸的有 icon 吗？间距也是这个吗？如果都没有定义的话不如直接在组件库实现里面特殊处理了。
There was a problem hiding this comment.
都有icon, 目前使用同样的间距
Justineo
reviewed
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11.13.0
Adjust tokens for tags.