Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The visibility selection to control ACL in the uploader should be configurable #1006

Closed
dagraf opened this issue Nov 21, 2023 · 6 comments · Fixed by #1305
Closed

The visibility selection to control ACL in the uploader should be configurable #1006

dagraf opened this issue Nov 21, 2023 · 6 comments · Fixed by #1305
Assignees
Labels
area:frontend Everything frontend related kind:improvement
Milestone

Comments

@dagraf
Copy link
Collaborator

dagraf commented Nov 21, 2023

It should be possible for application administrators to decide whether the visibility selection to control ACL should be offered in the uploader or not.

Reason: At our institution (University of Bern) and I guess also in many other institutions the uploaded videos get the visibility from the series they are part of.

@dagraf dagraf added area:frontend Everything frontend related kind:improvement labels Nov 21, 2023
@oas777
Copy link
Collaborator

oas777 commented Nov 21, 2023

Can you explain this a bit more with respect to https://tobira.opencast.org/~manage/upload? The "Access policy" part of that page would disappear once you have selected a series because that series then decides the visibility/access policies?

@LukasKalbertodt
Copy link
Member

My suggestion would be to not hide the UI, but make it greyed-out "read only", showing the access policy of the series. And add a note "access is determined by series" (in a more user friendly way).

I think we will tackle this as part of the more general "what's the deal with inheriting ACLs from series?" task. We should really look into this...

@dagraf
Copy link
Collaborator Author

dagraf commented Nov 22, 2023

My first thought was to give application administrators the opportunity to hide the Access policy part on the upload page totally. We are doing this in Opencast when people manually upload videos into a series. But the idea of Lukas to make it greyed-out "read only" and add a note which explain this sounds reasonable, too.
I would not expect this to be the default but to make it configurable: Institutions should be able to decide whether they want the access policy part on the upload page in write or read-only mode.

Let's discuss this in an upcoming meeting.

@oas777
Copy link
Collaborator

oas777 commented Nov 22, 2023

Questions for that discussion:

  • Can you see the accessibility rules of the series you select for your upload (so that you don't select a public series by accident)?
  • Can you upload an episode without selecting a series?
  • Or will that orphan episode automatically become part of the user's series?

@LukasKalbertodt
Copy link
Member

Can you see the accessibility rules of the series you select for your upload (so that you don't select a public series by accident)?

That's what I suggested and I think it makes sense.

Can you upload an episode without selecting a series?

That's configurable.

Or will that orphan episode automatically become part of the user's series?

No such feature exists yet.

@LukasKalbertodt LukasKalbertodt added this to the v2.5 milestone Dec 14, 2023
@LukasKalbertodt LukasKalbertodt moved this to Todo in Tobira Jan 10, 2024
@LukasKalbertodt LukasKalbertodt modified the milestones: v2.6, v2.7 Feb 14, 2024
@LukasKalbertodt LukasKalbertodt removed this from the v2.7 milestone Mar 12, 2024
@LukasKalbertodt LukasKalbertodt added this to the v3.0 milestone Dec 3, 2024
@owi92 owi92 self-assigned this Dec 12, 2024
LukasKalbertodt added a commit that referenced this issue Jan 20, 2025
This will disable ACL editing for the uploader and the ACL UI when the
video is part of a series.
Uploaded videos will then adopt the ACL of that series.

This needs to be configured with `lock_acl_to_series`, the default for
this is `false`.

Closes #1006
@LukasKalbertodt
Copy link
Member

Done in #1305

@github-project-automation github-project-automation bot moved this from Todo to Done ✔️ in Tobira Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Everything frontend related kind:improvement
Projects
Status: Done ✔️
Development

Successfully merging a pull request may close this issue.

4 participants