Add config to lock video ACLs to their series #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
owi92
force-pushed
the
acl-upload-config
branch
from
3d53a9f to
119ad94
Compare
github-actions
bot
removed
the
status:conflicts
LukasKalbertodt
requested changes
Jan 15, 2025
owi92
force-pushed
the
acl-upload-config
branch
from
119ad94 to
b0490c8
Compare
LukasKalbertodt
requested changes
Jan 16, 2025
Comment on lines
+704
to
+708
| const data = await fetchQuery<UploadSeriesAclQuery>( | ||
| environment, | ||
| SeriesAclQuery, | ||
| { seriesId } | ||
| ).toPromise(); |
There was a problem hiding this comment.
I think useQueryLoader is more idiomatic here? :/ But mhhh not sure if it's worth it changing that. It would also change the UX a bit: the ACL UI would be completely hidden while loading instead of showing the old value. Not sure if thats better or worse. So yeah no hard opinion, we can probably just keep it...
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
With this enabled, event ACLs can't be edited and will generally be determined by their series.
owi92
force-pushed
the
acl-upload-config
branch
from
b0490c8 to
34f9159
Compare
github-actions
bot
removed
the
status:conflicts
And then also disable ACL editing and attachment. In a previous iteration, this was using a suboptimal approach where each series returned by the API would send an additional query to get the series ACL. Now this only sends a single additional query whenever a series is actually selected. While this requires more code, a good amount of it is just state management and error handling/reporting. The rest is related to the data fetching.
owi92
force-pushed
the
acl-upload-config
branch
from
34f9159 to
b3a10b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will disable ACL editing for the uploader and the ACL UI when the video is part of a series.
Uploaded videos will then adopt the ACL of that series.
This needs to be configured with
lock_acl_to_series, the default for this isfalse.Closes #1006