[patch] only run extra install commands if deps were installed

electrovir · Nov 26, 2024 · 14bf919 · 14bf919
1 parent 0054918
commit 14bf919
Show file tree

Hide file tree

Showing 18 changed files with 93 additions and 93 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@virmator/mono-repo-root",
-    "version": "13.8.2",
+    "version": "13.8.3",
     "private": true,
     "type": "module",
     "workspaces": [

diff --git a/packages/compile/package.json b/packages/compile/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@virmator/compile",
-    "version": "13.8.2",
+    "version": "13.8.3",
     "description": "Default TS compile plugin for virmator.",
     "keywords": [
         "virmator",
@@ -34,12 +34,12 @@
         "@augment-vir/assert": "^30.8.2",
         "@augment-vir/common": "^30.8.2",
         "@augment-vir/node": "^30.8.2",
-        "@virmator/core": "^13.8.2"
+        "@virmator/core": "^13.8.3"
     },
     "devDependencies": {
         "@augment-vir/test": "^30.8.2",
         "@types/node": "^22.9.0",
-        "@virmator/plugin-testing": "^13.8.2",
+        "@virmator/plugin-testing": "^13.8.3",
         "c8": "^10.1.2",
         "chalk": "^5.3.0",
         "concurrently": "^9.1.0",

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@virmator/core",
-    "version": "13.8.2",
+    "version": "13.8.3",
     "description": "Shared core functionality for all virmator plugins and the virmator CLI.",
     "keywords": [
         "automation",

diff --git a/packages/core/src/api/install-deps.ts b/packages/core/src/api/install-deps.ts
@@ -112,16 +112,14 @@ export async function installNpmDeps({
         },
     );
 
-    const depsToInstallEntries = Object.entries(depsThatNeedInstalling);
-
-    await awaitedBlockingMap(
-        depsToInstallEntries,
+    const installed = await awaitedBlockingMap(
+        Object.entries(depsThatNeedInstalling),
         async ([
             depType,
             deps,
         ]) => {
             if (!deps.length) {
-                return;
+                return false;
             }
 
             const installDeps: string = deps.join(' ');
@@ -141,10 +139,12 @@ export async function installNpmDeps({
                 hookUpToConsole: true,
                 rejectOnError: true,
             });
+
+            return true;
         },
     );
 
-    return !!depsToInstallEntries.length;
+    return installed.some(check.isTrue);
 }
 
 function combineDeps(packageJson: Readonly<PackageJson>) {

diff --git a/packages/deps/package.json b/packages/deps/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@virmator/deps",
-    "version": "13.8.2",
+    "version": "13.8.3",
     "description": "Default TS deps plugin for virmator.",
     "keywords": [
         "virmator",
@@ -36,7 +36,7 @@
         "@augment-vir/assert": "^30.8.2",
         "@augment-vir/common": "^30.8.2",
         "@augment-vir/node": "^30.8.2",
-        "@virmator/core": "^13.8.2",
+        "@virmator/core": "^13.8.3",
         "mri": "^1.2.0"
     },
     "devDependencies": {

diff --git a/packages/docs/package.json b/packages/docs/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@virmator/docs",
-    "version": "13.8.2",
+    "version": "13.8.3",
     "description": "Default TS docs plugin for virmator.",
     "keywords": [
         "virmator",
@@ -35,7 +35,7 @@
         "@augment-vir/assert": "^30.8.2",
         "@augment-vir/common": "^30.8.2",
         "@augment-vir/node": "^30.8.2",
-        "@virmator/core": "^13.8.2",
+        "@virmator/core": "^13.8.3",
         "chalk": "^5.3.0",
         "mri": "^1.2.0"
     },