-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure-kubernetes] Add eoas date to Azure Kubernetes 1.30 #6166
base: master
Are you sure you want to change the base?
[azure-kubernetes] Add eoas date to Azure Kubernetes 1.30 #6166
Conversation
Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals. |
cc @MathieuPuech @chenrui333 as author and reviewer of #6123 |
Could you make at least the |
Just for clarity:
As such:
|
Ok this is a little confusing, so just to check. The |
Yes, that's correct. |
It looks like this PR was superseded by #6230. I've updated this PR to just add an |
…date into azure-127-lts
@jacobtomlinson isnt 1.32 released ? could you also add it ( if it also released ) |
@usta not yet on Azure Kubernetes Service, it looks scheduled to be released some time in February. |
@jacobtomlinson thank you for your contributions brother 💯 👍 🥇 |
In #6123 an LTS date for Azure Kubernetes
1.30
was added. The fields used are inconsistent with the existing LTS dates for1.27
.In
1.27
theeol
field was used for the LTS EOL date, and thelts
field was used for the original non-LTS eol date. In1.30
these fields have been switched. The1.27
data also has aneoas
field with the same value aslts
which gets rendered as a field calledsupport
which does not exist for1.30
.It makes more sense to me to use the
eol
field for the original non-LTS EOL date, and thelts
field for the extended LTS EOL date. So this PR updates the1.27
data to be consistent with the1.30
data.