Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-kubernetes] Add eoas date to Azure Kubernetes 1.30 #6166

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jacobtomlinson
Copy link

In #6123 an LTS date for Azure Kubernetes 1.30 was added. The fields used are inconsistent with the existing LTS dates for 1.27.

In 1.27 the eol field was used for the LTS EOL date, and the lts field was used for the original non-LTS eol date. In 1.30 these fields have been switched. The 1.27 data also has an eoas field with the same value as lts which gets rendered as a field called support which does not exist for 1.30.

It makes more sense to me to use the eol field for the original non-LTS EOL date, and the lts field for the extended LTS EOL date. So this PR updates the 1.27 data to be consistent with the 1.30 data.

Copy link

welcome bot commented Nov 5, 2024

Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals.

@jacobtomlinson
Copy link
Author

cc @MathieuPuech @chenrui333 as author and reviewer of #6123

@chenrui333 chenrui333 added the release-updates Pull Requests that update release information label Nov 5, 2024
@usta usta changed the title Make Azure Kubernetes LTS dates consistent [azure-kubernetes] Fix LTS dates Dec 20, 2024
@usta
Copy link
Member

usta commented Dec 20, 2024

Could you make at least the releaseDate(1.30) and EOL|LTS(1.7) same ?

@captn3m0
Copy link
Member

Just for clarity:

lts is meant to hold the LTS status for a release (bool). In case an exact LTS start date is available (since many products promote a release to LTS after some time), we use the lts parameter as a date. This is the relevant explanation from https://endoflife.date/contribute:

# Whether this is a "LTS" release (optional, default = false).
# What LTS means may differ from product to product (see LTSLabel above).
# Only provide for a release that will get much longer support than usual.
# Alternatively, this can be set to a date when the product is not labeled
# as LTS when it is released (ex. Angular) or when normal versions are
# promoted LTS after their release (ex. Jenkins).

As such:

  • lts should be set to the midway mark for LTS release (releaseDate+1y)
  • eol should be set to releaseDate + 1y for non-LTS releases, and releaseDate + 2y for LTS releases.

@jacobtomlinson
Copy link
Author

Ok this is a little confusing, so just to check. The lts paramater should be set to the date the LTS support starts, and eol should be set to the date LTS support ends?

@captn3m0
Copy link
Member

captn3m0 commented Jan 6, 2025

Yes, that's correct.

@jacobtomlinson
Copy link
Author

jacobtomlinson commented Jan 7, 2025

It looks like this PR was superseded by #6230. I've updated this PR to just add an eoas parameter to match what already exists for 1.27 (I assume this stands for end of active support).

@jacobtomlinson jacobtomlinson changed the title [azure-kubernetes] Fix LTS dates [azure-kubernetes] Add eoas date to Azure Kubernetes 1.30 Jan 7, 2025
@usta
Copy link
Member

usta commented Jan 7, 2025

@jacobtomlinson isnt 1.32 released ? could you also add it ( if it also released )

@jacobtomlinson
Copy link
Author

@usta not yet on Azure Kubernetes Service, it looks scheduled to be released some time in February.

https://learn.microsoft.com/en-us/azure/aks/supported-kubernetes-versions?tabs=azure-cli#aks-kubernetes-release-calendar

@usta
Copy link
Member

usta commented Jan 7, 2025

@jacobtomlinson thank you for your contributions brother 💯 👍 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-updates Pull Requests that update release information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants