fix(rating#4445): update model-value to modelValue case in the te…
#4450
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuestic-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for vuestic-docs failed. Why did it fail? →
|
m0ksem
requested changes
Jan 10, 2025
| @@ -22,6 +22,8 @@ export const useIsUserProvidedProp = (propName: string) => { | |||
| if (!vm?.vnode.props) { return false } | |||
|
|
|||
| // If vnode doesn't have this prop it mean default value is used | |||
| // Note: be cautious as the `propName` should have the exact case in the template | |||
There was a problem hiding this comment.
UserProvidedProp is used outside of Vuestic internals. We need to to work with both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should close #4445
Types of changes