Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed column name to remove duplicate #509

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

DForck42
Copy link
Contributor

@DForck42 DForck42 commented Dec 9, 2024

changed the second column named blocked_process_report to blocked_process_report_xml

changed the second column named blocked_process_report to blocked_process_report_xml
Copy link
Owner

@erikdarlingdata erikdarlingdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're not used to GitHub, I'm going to point you to a helpful thing:

  1. Please review the contributing guide

I've linked directly to the code standards section. There is one point in there directly related to this PR, and another close by.

  1. Column aliases using the "column = expression" format - you've not done that, but the opposite of that. It should be blocked_process_report_xml = b.blocked_process_report
  2. Using AS in table aliases we are not dodo birds, we capitalize key words in our SQL.

@DForck42
Copy link
Contributor Author

ope, somehow missed that

@erikdarlingdata
Copy link
Owner

@DForck42 thank you!

@erikdarlingdata erikdarlingdata merged commit 089a2e0 into erikdarlingdata:dev Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants