Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplify main by using new esp-box, t-deck, and wrover-kit components #6

Merged
merged 6 commits into from
Jul 6, 2024

Conversation

finger563
Copy link
Contributor

Description

Replace old manual configuration code for display, touchscreen, and other hardware with use of new esp-box, t-deck, and wrover-kit components.

Motivation and Context

Allows for code-reuse among projects and makes this code easier to read and understand.

How has this been tested?

Building and running main on the relevant hardwares.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit caa35a7 into main Jul 6, 2024
2 checks passed
@finger563 finger563 deleted the feature/espp-update-esp-box-component branch July 6, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant