Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add downgrade cancellation e2e tests #17976

Open
henrybear327 opened this issue May 9, 2024 · 8 comments
Open

Add downgrade cancellation e2e tests #17976

henrybear327 opened this issue May 9, 2024 · 8 comments
Assignees
@henrybear327 @siyuanfoundation
Labels
area/testing priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@henrybear327
Copy link
Contributor

What would you like to be added?

Add e2e tests for downgrade cancellation.

Why is this needed?

Improves test coverage for downgrade procedure which is critical for implementing downgrade support.
@henrybear327
Copy link
Contributor Author

/cc @siyuanfoundation
/assign @henrybear327

@jmhbnz jmhbnz added area/testing priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 9, 2024
@ahrtr
Copy link
Member

ahrtr commented Dec 5, 2024

@henrybear327 are you still working on this?

@henrybear327
Copy link
Contributor Author

henrybear327 commented Dec 5, 2024 •
edited
Loading

@henrybear327 are you still working on this?

Yes @ahrtr! I have a branch that I never fully finish, sorry. I will polish it and submit it for review ASAP.

@ahrtr
Copy link
Member

ahrtr commented Dec 6, 2024

Discussed with @serathius, the intention is to ensure the cluster can be reverted to the original state in case any error happens during the downgrade.

@ahrtr
Copy link
Member

ahrtr commented Jan 8, 2025

@henrybear327 any update on this?

@ahrtr ahrtr mentioned this issue Jan 15, 2025
Merged
@henrybear327
Copy link
Contributor Author

@henrybear327 any update on this?

Had a call with @siyuanfoundation today and discussed. PR will be up this weekend.

@henrybear327 henrybear327 mentioned this issue Jan 21, 2025
Open
@henrybear327
Copy link
Contributor Author

Hey @ahrtr @siyuanfoundation,

First part of the e2e test is delivered here #19244.

The partial downgraded cluster cancellation PR will be delivered by the end of today, as I have a bug with it. Sorry that I probably should have broken it down when I was debugging so it won't look like there is no progress made so far...

@henrybear327 henrybear327 self-assigned this Jan 21, 2025
@henrybear327 henrybear327 mentioned this issue Jan 21, 2025
Draft
@henrybear327
Copy link
Contributor Author

The partial downgraded cluster cancellation PR is delivered here #19252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrybear327 henrybear327

@siyuanfoundation siyuanfoundation

Labels
area/testing priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Milestone
No milestone
Development

No branches or pull requests
4 participants
@henrybear327 @siyuanfoundation @ahrtr @jmhbnz