Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downgrade cancellation e2e tests #19252

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

henrybear327
Copy link
Contributor

Part 2 of the e2e test - downgrade cancellation is called after the cluster has been partially downgraded

This PR is currently based on #19244, thus, it's put in draft mode for now.

Reference: #17976

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (532c601) to head (7afa927).

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19252      +/-   ##
==========================================
+ Coverage   68.87%   68.88%   +0.01%     
==========================================
  Files         420      420              
  Lines       35680    35680              
==========================================
+ Hits        24573    24579       +6     
+ Misses       9685     9679       -6     
  Partials     1422     1422              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532c601...7afa927. Read the comment docs.

ret[i] = &version.Versions{
Cluster: ver.String(),
Server: e2e.OffsetMinor(ver, 1).String(),
Storage: "",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will continue to investigate this tomorrow

@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from fe607d8 to 1ae6cba Compare January 24, 2025 19:04
@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from 1ae6cba to 7afa927 Compare January 26, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants