-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compaction to kubernetes robustness tests #19233
Add compaction to kubernetes robustness tests #19233
Conversation
Hi @AwesomePatrol. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #19233 +/- ##
==========================================
- Coverage 68.82% 68.79% -0.04%
==========================================
Files 420 420
Lines 35649 35649
==========================================
- Hits 24536 24525 -11
- Misses 9692 9700 +8
- Partials 1421 1424 +3 Continue to review full report in Codecov by Sentry.
|
28e6519
to
db06a8b
Compare
Please consider splitting PRs. |
db06a8b
to
9273725
Compare
Signed-off-by: Marek Siarkowicz <[email protected]>
9273725
to
845a330
Compare
return | ||
} | ||
|
||
compactTime, rev, err = compact(ctx, c, compactTime, rev) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed we don't set timeout here. Don't know if that an issue, but it might need a followup. As a separate process that doesn't have a failure condition, it would be good to put some external validation. For example validate that at least 1 compaction request was recorded.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AwesomePatrol, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previously proposed in #18773