Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compaction to kubernetes robustness tests #19233

Conversation

AwesomePatrol
Copy link
Contributor

Previously proposed in #18773

@k8s-ci-robot
Copy link

Hi @AwesomePatrol. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (0dcd015) to head (845a330).
Report is 2 commits behind head on main.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19233      +/-   ##
==========================================
- Coverage   68.82%   68.79%   -0.04%     
==========================================
  Files         420      420              
  Lines       35649    35649              
==========================================
- Hits        24536    24525      -11     
- Misses       9692     9700       +8     
- Partials     1421     1424       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dcd015...845a330. Read the comment docs.

@AwesomePatrol AwesomePatrol force-pushed the add-compaction-to-kubernetess-robustness-tests branch from 28e6519 to db06a8b Compare January 21, 2025 09:07
@serathius
Copy link
Member

Please consider splitting PRs.

@AwesomePatrol AwesomePatrol force-pushed the add-compaction-to-kubernetess-robustness-tests branch from db06a8b to 9273725 Compare January 21, 2025 10:24
@AwesomePatrol AwesomePatrol marked this pull request as ready for review January 21, 2025 10:25
@AwesomePatrol AwesomePatrol force-pushed the add-compaction-to-kubernetess-robustness-tests branch from 9273725 to 845a330 Compare January 21, 2025 11:05
return
}

compactTime, rev, err = compact(ctx, c, compactTime, rev)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed we don't set timeout here. Don't know if that an issue, but it might need a followup. As a separate process that doesn't have a failure condition, it would be good to put some external validation. For example validate that at least 1 compaction request was recorded.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 7c56ef2 into etcd-io:main Jan 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants